Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: frog/member.dart

Issue 9129023: adds array bounds checking (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merged Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/lib/corelib_impl.dart ('k') | frog/minfrog » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index 71a63ea8c6246cf403e2d7ea4d0aa97370c07370..dedf1556b70c81a39834c2f2e6244a1b1e1b1071 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -1138,12 +1138,11 @@ class MethodMember extends Member {
return new Value(declaringType, '${target.code} + ${argsCode[0]}',
node.span);
}
- } else if (declaringType.isNative) {
+ } else if (declaringType.isNative && options.disableBoundsChecks) {
if (args.length > 0 && args.values[0].type.isNum) {
- // TODO(jimhug): make more accurate/reliable
if (name == ':index') {
- return
- new Value(returnType, '${target.code}[${argsCode[0]}]', node.span);
+ return new Value(returnType,
+ '${target.code}[${argsCode[0]}]', node.span);
} else if (name == ':setindex') {
return new Value(returnType,
'${target.code}[${argsCode[0]}] = ${argsCode[1]}', node.span);
« no previous file with comments | « frog/lib/corelib_impl.dart ('k') | frog/minfrog » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698