Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 9129016: Ignore Shift+Search when spoken feedback is enabled. (Closed)

Created:
7 years, 1 month ago by Yusuke Sato
Modified:
7 years, 1 month ago
CC:
chromium-reviews, hashimoto
Visibility:
Public.

Description

Ignore Shift+Search when spoken feedback is enabled. This change depends on http://codereview.chromium.org/9225004/. BUG=110127 TEST=manual, ran browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119523

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/ui/views/aura/caps_lock_handler.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yusuke Sato
7 years, 1 month ago (2012-01-24 10:28:24 UTC) #1
Zachary Kuznia
lgtm
7 years, 1 month ago (2012-01-24 13:31:10 UTC) #2
dmazzoni
http://codereview.chromium.org/9129016/diff/1/chrome/browser/ui/views/aura/caps_lock_handler.cc File chrome/browser/ui/views/aura/caps_lock_handler.cc (right): http://codereview.chromium.org/9129016/diff/1/chrome/browser/ui/views/aura/caps_lock_handler.cc#newcode47 chrome/browser/ui/views/aura/caps_lock_handler.cc:47: !g_browser_process->local_state()->GetBoolean( This is great, but I'm afraid the next ...
7 years, 1 month ago (2012-01-24 18:43:56 UTC) #3
dmazzoni
lgtm (no need to wait for another review, submit when ready)
7 years, 1 month ago (2012-01-24 18:44:59 UTC) #4
Yusuke Sato
+ben (chrome/browser/ui/ owner) Could you take a look? http://codereview.chromium.org/9129016/diff/1/chrome/browser/ui/views/aura/caps_lock_handler.cc File chrome/browser/ui/views/aura/caps_lock_handler.cc (right): http://codereview.chromium.org/9129016/diff/1/chrome/browser/ui/views/aura/caps_lock_handler.cc#newcode47 chrome/browser/ui/views/aura/caps_lock_handler.cc:47: !g_browser_process->local_state()->GetBoolean( ...
7 years, 1 month ago (2012-01-25 01:43:16 UTC) #5
Ben Goodger (Google)
lgtm
7 years, 1 month ago (2012-01-26 16:32:27 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2012-01-27 23:12:09 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698