Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 9129013: Panel Overflow on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
index b4f0e6d263a61287cf050565300c00b929d1067f..40f7c74c705a09684ced12335820956283aed336 100644
--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
@@ -26,7 +26,6 @@
#import "chrome/browser/ui/cocoa/tab_contents/favicon_util.h"
#import "chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h"
#import "chrome/browser/ui/cocoa/tabs/throbber_view.h"
-#include "chrome/browser/ui/panels/panel.h"
#include "chrome/browser/ui/panels/panel_bounds_animation.h"
#include "chrome/browser/ui/panels/panel_browser_window_cocoa.h"
#include "chrome/browser/ui/panels/panel_manager.h"
@@ -535,6 +534,17 @@ enum {
return NSHeight([titlebar convertRect:[titlebar bounds] toView:nil]);
}
+- (int)titlebarIconOnlyWidthInScreenCoordinates {
+ return [[self titlebarView] iconOnlyWidthInScreenCoordinates];
+}
+
+- (void)applyVisualStyleForStrip:(PanelStripType)newPanelStrip {
+ if (windowShim_->panel()->manager()->is_full_screen())
+ return;
+ [[self window] setLevel:(newPanelStrip == OVERFLOW_STRIP ?
+ NSStatusWindowLevel + 1 : NSStatusWindowLevel)];
+}
+
// TODO(dcheng): These two selectors are almost copy-and-paste from
// BrowserWindowController. Figure out the appropriate way of code sharing,
// whether it's refactoring more things into BrowserWindowUtils or making a

Powered by Google App Engine
This is Rietveld 408576698