Issue 9129009: Change tool-bar behaviour to click-to-show.

Issue 9129009: Change tool-bar behaviour to click-to-show. (Closed)

Created:
8 years, 11 months ago by Jamie

Modified:
8 years, 10 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change tool-bar behaviour to click-to-show. This is based on user feedback the auto-show behaviour makes it hard to access the top of the host screen. By auto-expanding only the stub, the inaccessible part of the host screen is reduced. BUG=110211 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120093

Patch Set 1 #

Patch Set 2 : Iterating based on UX feedback. #

Patch Set 3 : Fixed linter errors and comment. #

Total comments: 4

Patch Set 4 : Fixed copyright dates. #

Patch Set 5 : Rebase #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -79 lines)			Patch
M	remoting/webapp/choice.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/webapp/client_screen.js	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/webapp/event_handlers.js	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	remoting/webapp/toolbar.css	View	1 2 3	4 chunks	+28 lines, -7 lines	0 comments	Download
M	remoting/webapp/toolbar.js	View	1 2 3	4 chunks	+77 lines, -68 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

garykac

LGTM https://chromiumcodereview.appspot.com/9129009/diff/3001/remoting/webapp/event_handlers.js File remoting/webapp/event_handlers.js (right): https://chromiumcodereview.appspot.com/9129009/diff/3001/remoting/webapp/event_handlers.js#newcode58 remoting/webapp/event_handlers.js:58: fn: function() { remoting.toolbar.toggle(); } }, Does { ...

8 years, 10 months ago (2012-02-01 18:24:48 UTC) #2

Jamie

8 years, 10 months ago (2012-02-01 19:22:20 UTC) #3

https://chromiumcodereview.appspot.com/9129009/diff/3001/remoting/webapp/even...
File remoting/webapp/event_handlers.js (right):

https://chromiumcodereview.appspot.com/9129009/diff/3001/remoting/webapp/even...
remoting/webapp/event_handlers.js:58: fn: function() {
remoting.toolbar.toggle(); } },
On 2012/02/01 18:24:48, garykac wrote:
> Does
>   { ..., fn: remoting.toolbar.toggle },
> work?

remoting.toolbar is null when this is invoked, but I'm pretty sure it wouldn't
work even if it wasn't.

https://chromiumcodereview.appspot.com/9129009/diff/3001/remoting/webapp/tool...
File remoting/webapp/toolbar.js (right):

https://chromiumcodereview.appspot.com/9129009/diff/3001/remoting/webapp/tool...
remoting/webapp/toolbar.js:114: var threshold = 50;
On 2012/02/01 18:24:48, garykac wrote:
> I have concerns that this threshold might be too large, but we'll have to see
> how well it works with the users.

You may be right. I'm certainly happy to iterate on this.

Expand Messages | Collapse Messages