Work on improving PpbAudioConfig:RecommendSampleFrameCount

ppapi/proxy/ppb_instance_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_instance_proxy.h"
 
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/pp_var.h"
+#include "ppapi/c/ppb_audio_config.h"
 #include "ppapi/c/ppb_instance.h"
 #include "ppapi/c/ppb_messaging.h"
 #include "ppapi/c/ppb_mouse_lock.h"
 #include "ppapi/proxy/enter_proxy.h"
 #include "ppapi/proxy/host_dispatcher.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/serialized_var.h"
 #include "ppapi/shared_impl/ppapi_globals.h"
 #include "ppapi/shared_impl/ppb_url_util_shared.h"
@@ skipping 54 matching lines @@
   IPC_BEGIN_MESSAGE_MAP(PPB_Instance_Proxy, msg)
     // Plugin -> Host messages.
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_GetWindowObject,
                         OnHostMsgGetWindowObject)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_GetOwnerElementObject,
                         OnHostMsgGetOwnerElementObject)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_BindGraphics,
                         OnHostMsgBindGraphics)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_IsFullFrame,
                         OnHostMsgIsFullFrame)
+    IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_AudioHardwareOutputSampleRate,
+                        OnHostMsgAudioHardwareOutputSampleRate)
+    IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_AudioHardwareOutputBufferSize,
+                        OnHostMsgAudioHardwareOutputBufferSize)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_ExecuteScript,
                         OnHostMsgExecuteScript)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_GetDefaultCharSet,
                         OnHostMsgGetDefaultCharSet)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_PostMessage,
                         OnHostMsgPostMessage)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_FlashSetFullscreen,
                         OnHostMsgFlashSetFullscreen)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBInstance_FlashGetScreenSize,
                         OnHostMsgFlashGetScreenSize)
@@ skipping 83 matching lines @@
   if (se.IsThrown())
     return PP_MakeUndefined();
 
   ReceiveSerializedVarReturnValue result;
   dispatcher()->Send(new PpapiHostMsg_PPBInstance_ExecuteScript(
       API_ID_PPB_INSTANCE, instance,
       SerializedVarSendInput(dispatcher(), script), &se, &result));
   return result.Return(dispatcher());
 }
 
+uint32_t PPB_Instance_Proxy::

[brettw, 2012/02/10 19:01:33]

Style: Don't wrap after the :: if you don't need to, wrap the arg to 4 spaces.
Same below. 

[nfullagar, 2012/02/14 00:42:37]

Done.

+    AudioHardwareOutputSampleRate(PP_Instance instance) {
+  uint32_t result = PP_AUDIOSAMPLERATE_NONE;
+  dispatcher()->Send(new PpapiHostMsg_PPBInstance_AudioHardwareOutputSampleRate(

[brettw, 2012/02/10 19:01:33]

Can the messages and handlers be made to match the function (...Recommend...).
The way you have this looks like the sample rate is being broadcast rather than
retrieved.

[nfullagar, 2012/02/14 00:42:37]

Changed to GetAudio... (as you suggested in a later comment)

+      API_ID_PPB_INSTANCE, instance, &result));
+  return result;
+}
+
+uint32_t PPB_Instance_Proxy::
+    AudioHardwareOutputBufferSize(PP_Instance instance) {
+  uint32_t result = 0;
+  dispatcher()->Send(new PpapiHostMsg_PPBInstance_AudioHardwareOutputBufferSize(
+      API_ID_PPB_INSTANCE, instance, &result));
+  return result;
+}
+
 PP_Var PPB_Instance_Proxy::GetDefaultCharSet(PP_Instance instance) {
   PluginDispatcher* dispatcher = PluginDispatcher::GetForInstance(instance);
   if (!dispatcher)
     return PP_MakeUndefined();
 
   ReceiveSerializedVarReturnValue result;
   dispatcher->Send(new PpapiHostMsg_PPBInstance_GetDefaultCharSet(
       API_ID_PPB_INSTANCE, instance, &result));
   return result.Return(dispatcher);
 }
@@ skipping 201 matching lines @@
 void PPB_Instance_Proxy::OnHostMsgBindGraphics(PP_Instance instance,
                                                const HostResource& device,
                                                PP_Bool* result) {
   EnterInstanceNoLock enter(instance, false);
   if (enter.succeeded()) {
     *result = enter.functions()->BindGraphics(instance,
                                               device.host_resource());
   }
 }
 
+void PPB_Instance_Proxy::OnHostMsgAudioHardwareOutputSampleRate(
+    PP_Instance instance, uint32_t* result) {
+  EnterInstanceNoLock enter(instance, false);
+  if (enter.succeeded())
+    *result = enter.functions()->AudioHardwareOutputSampleRate(instance);
+}
+
+void PPB_Instance_Proxy::OnHostMsgAudioHardwareOutputBufferSize(
+    PP_Instance instance, uint32_t* result) {
+  EnterInstanceNoLock enter(instance, false);
+  if (enter.succeeded())
+    *result = enter.functions()->AudioHardwareOutputBufferSize(instance);
+}
+
 void PPB_Instance_Proxy::OnHostMsgIsFullFrame(PP_Instance instance,
                                               PP_Bool* result) {
   EnterInstanceNoLock enter(instance, false);
   if (enter.succeeded())
     *result = enter.functions()->IsFullFrame(instance);
 }
 
 void PPB_Instance_Proxy::OnHostMsgExecuteScript(
     PP_Instance instance,
     SerializedVarReceiveInput script,
@@ skipping 160 matching lines @@
 }
 
 void PPB_Instance_Proxy::MouseLockCompleteInHost(int32_t result,
                                                  PP_Instance instance) {
   dispatcher()->Send(new PpapiMsg_PPBInstance_MouseLockComplete(
       API_ID_PPB_INSTANCE, instance, result));
 }
 
 }  // namespace proxy
 }  // namespace ppapi