Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 9124033: Hook up the SequencedWorkerPool to the browser thread. (Closed)

Created:
8 years, 11 months ago by brettw
Modified:
8 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Hook up the SequencedWorkerPool to the browser thread. [re-land of 116816 http://codereview.chromium.org/9065009] This does some refactoring of the static data in the browser thread so we only have one global object instead of a bunch fo separate arrays. It also hooks up the visited link master's I/O to use this new system as a proof of concept. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118236

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -74 lines) Patch
M base/threading/sequenced_worker_pool.h View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 2 3 7 chunks +64 lines, -15 lines 0 comments Download
M chrome/browser/crash_upload_list.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_master.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_master.cc View 1 2 3 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_unittest.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/browser_thread_impl.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 2 3 14 chunks +98 lines, -44 lines 0 comments Download
M content/public/browser/browser_thread.h View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Re-land of the previous patch. I broke the unit tests for the visited link system, ...
8 years, 11 months ago (2012-01-07 23:56:03 UTC) #1
jam
http://codereview.chromium.org/9124033/diff/17001/base/threading/sequenced_worker_pool.h File base/threading/sequenced_worker_pool.h (right): http://codereview.chromium.org/9124033/diff/17001/base/threading/sequenced_worker_pool.h#newcode192 base/threading/sequenced_worker_pool.h:192: // Note that callin this will not prevent other ...
8 years, 11 months ago (2012-01-08 23:04:22 UTC) #2
brettw
Comments addressed, new snap up.
8 years, 11 months ago (2012-01-18 00:16:25 UTC) #3
jam
8 years, 11 months ago (2012-01-18 18:43:58 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698