Issue 9121075: Removing some dead flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9121075: Removing some dead flags. (Closed)

Created:
8 years, 10 months ago by Yang

Modified:
8 years, 10 months ago

Reviewers:
Kevin Millikin (Chromium), Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removing some dead flags. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10549

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -25 lines)			Patch
	M	src/bootstrapper.cc	View		1 chunk	+9 lines, -16 lines	0 comments	Download
	M	src/flag-definitions.h	View		4 chunks	+6 lines, -9 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

PTAL. http://codereview.chromium.org/9121075/diff/1/src/flag-definitions.h File src/flag-definitions.h (left): http://codereview.chromium.org/9121075/diff/1/src/flag-definitions.h#oldcode330 src/flag-definitions.h:330: DEFINE_bool(new_snapshot, true, "use new snapshot implementation") FLAG_h is ...

8 years, 10 months ago (2012-01-30 10:54:41 UTC) #1

Kevin Millikin (Chromium)

This is OK with me, but let's make sure Erik agrees that --new-snapshot is really ...

8 years, 10 months ago (2012-01-30 11:22:42 UTC) #2

LGTM

Expand Messages | Collapse Messages