Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 9121035: [hterm:crosh] Add support for terminal window resizing to terminal API (Closed)

Created:
8 years, 11 months ago by tbarzic
Modified:
8 years, 10 months ago
Reviewers:
rginda, Aaron Boodman
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

[HTerm-Crosh] Add support for terminal window resizing to terminal API Add method terminalPrivate.onTerminalResize that will be called by hterm when its window gets resized. This is needed by some app we might run in pseudo-terminal that need to know window size to work properly. BUG=chromium-os:25947 TEST=Open some file in crosh using vi, and verify that the file is shown in full terminal screen. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121827

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -6 lines) Patch
M chrome/browser/chromeos/process_proxy/process_proxy.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/process_proxy/process_proxy.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/process_proxy/process_proxy_registry.h View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/process_proxy/process_proxy_registry.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/terminal/terminal_private_api.h View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/terminal/terminal_private_api.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/terminalPrivate.json View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tbarzic
Hey guys, can you take a look? https://chromiumcodereview.appspot.com/9121035/diff/2001/chrome/browser/chromeos/process_proxy/process_proxy.cc File chrome/browser/chromeos/process_proxy/process_proxy.cc (right): https://chromiumcodereview.appspot.com/9121035/diff/2001/chrome/browser/chromeos/process_proxy/process_proxy.cc#newcode160 chrome/browser/chromeos/process_proxy/process_proxy.cc:160: if (width ...
8 years, 11 months ago (2012-01-27 04:14:27 UTC) #1
tbarzic
ping?
8 years, 10 months ago (2012-02-03 19:44:02 UTC) #2
rginda
lgtm http://codereview.chromium.org/9121035/diff/2001/chrome/browser/chromeos/process_proxy/process_proxy.cc File chrome/browser/chromeos/process_proxy/process_proxy.cc (right): http://codereview.chromium.org/9121035/diff/2001/chrome/browser/chromeos/process_proxy/process_proxy.cc#newcode160 chrome/browser/chromeos/process_proxy/process_proxy.cc:160: if (width < 0 || height < 0) ...
8 years, 10 months ago (2012-02-06 22:49:43 UTC) #3
Aaron Boodman
8 years, 10 months ago (2012-02-13 22:46:53 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698