Break a circular include dependency.

Break a circular include dependency.

1. heap-inl.h has a function Heap::_inline_get_heap_ that calls
Isolate::Current() defined in isolate.h, so heap-inl.h requires
isolate.h.

2. Isolate has an embedded Heap member, so isolate.h requires heap.h.

3. heap.h has inline functions functions defined that call
Heap::_inline_get_heap_, so heap.h requires heap-inl.h (!).

The upshot is that all three need to be included wherever one is.  A
simpler way is to break the cycle by moving the inlined functions in
heap.h to heap-inl.h.

R=vegorov@chromium.org
BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=10539

[Vyacheslav Egorov (Chromium), 2012-01-27 08:41:04]

lgtm

https://chromiumcodereview.appspot.com/9121033/diff/1/src/heap-inl.h
File src/heap-inl.h (right):

https://chromiumcodereview.appspot.com/9121033/diff/1/src/heap-inl.h#newcode730
src/heap-inl.h:730: void VerifyPointersVisitor::VisitPointers(Object** start,
Object** end) {
I think this will not compile in release mode (class is not defined).

https://chromiumcodereview.appspot.com/9121033/diff/1/src/heap-inl.h#newcode784
src/heap-inl.h:784: pDisableAssertNoAllocation::~DisableAssertNoAllocation() { }
I think this will not compile.

[Kevin Millikin (Chromium), 2012-01-27 15:48:10]

Thanks and thanks.