Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 9117038: Convert all remaining explicit LeakyLazyInstanceTraits users to ::Leaky (Closed)

Created:
8 years, 11 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 11 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, garykac+watch_chromium.org, cbentzel+watch_chromium.org, sanjeevr, creis+watch_chromium.org, nkostylev+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, ajwong+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, robertshield, simonmorris+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, sergeyu+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Convert all remaining explicit LeakyLazyInstanceTraits users to ::Leaky and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting new users. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119173

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -163 lines) Patch
M base/lazy_instance.h View 1 3 chunks +9 lines, -6 lines 0 comments Download
M base/mac/scoped_nsexception_enabler.mm View 3 chunks +2 lines, -3 lines 0 comments Download
M base/third_party/dmg_fp/dtoa_wrapper.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M base/threading/platform_thread_mac.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M base/threading/platform_thread_posix.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/threading/thread_restrictions.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/web_socket_proxy.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/debugger/devtools_file_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/internal_auth.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/system_settings_provider2.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/mac/objc_zombie.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/browsing_instance.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/browsing_instance.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M content/browser/debugger/render_view_devtools_agent_host.cc View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/net/url_request_slow_download_job.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/net/url_request_slow_download_job.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/renderer_host/java/java_method.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M content/common/np_channel_base.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/common/socket_stream_dispatcher.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M content/renderer/devtools_agent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/indexed_db/indexed_db_dispatcher.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/base/ev_root_ca_metadata.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/base/ssl_config_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/base/test_root_certs_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/base/x509_certificate_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request_test_job.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/shared_impl/ppapi_globals.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/local_input_monitor_mac.mm View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/host/local_input_monitor_thread_win.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/host/plugin/host_log_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/worker_task_runner.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_ime_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Ami GONE FROM CHROMIUM
evan: please OK the move to base::internal estade/thakis/jam/wtc/kbr/piman/wez/tony: please OWNERS-stamp your resp dirs. https://chromiumcodereview.appspot.com/9117038/diff/1/content/browser/browsing_instance.h File ...
8 years, 11 months ago (2012-01-24 18:14:26 UTC) #1
piman
rubber-stamp LGTM for content/renderer and ppapi
8 years, 11 months ago (2012-01-24 18:19:55 UTC) #2
Nico
lgtm for my directories
8 years, 11 months ago (2012-01-24 18:20:21 UTC) #3
wtc
Patch set 1 LGTM. I only reviewed base/lazy_instance.h, content/browser/net, and net. https://chromiumcodereview.appspot.com/9117038/diff/1/base/lazy_instance.h File base/lazy_instance.h (right): ...
8 years, 11 months ago (2012-01-24 19:39:52 UTC) #4
tony
rs LGTM for webkit/ Nit: Did you want to re-wrap lines that are now shorter?
8 years, 11 months ago (2012-01-24 19:49:10 UTC) #5
Ami GONE FROM CHROMIUM
On 2012/01/24 19:49:10, tony wrote: > rs LGTM for webkit/ Thanks. > Nit: Did you ...
8 years, 11 months ago (2012-01-24 20:25:04 UTC) #6
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/9117038/diff/1/base/lazy_instance.h File base/lazy_instance.h (right): https://chromiumcodereview.appspot.com/9117038/diff/1/base/lazy_instance.h#newcode83 base/lazy_instance.h:83: // base::LazyInstance<T, LeakyLazyInstanceTraits<T> > my_leaky_lazy_instance; On 2012/01/24 19:39:53, wtc ...
8 years, 11 months ago (2012-01-24 20:27:30 UTC) #7
jam
content/browser content/common lgtm nice, this is easier on the eyes
8 years, 11 months ago (2012-01-24 20:57:31 UTC) #8
Ken Russell (switch to Gerrit)
GPU stuff LGTM
8 years, 11 months ago (2012-01-24 21:56:12 UTC) #9
Evan Stade
webui lgtm
8 years, 11 months ago (2012-01-24 22:03:22 UTC) #10
Wez
remoting/ LGTM.
8 years, 11 months ago (2012-01-25 18:39:38 UTC) #11
Ami GONE FROM CHROMIUM
evanm: ping?
8 years, 11 months ago (2012-01-25 19:00:44 UTC) #12
Evan Martin
rubber stamp On Wed, Jan 25, 2012 at 11:00 AM, <fischman@chromium.org> wrote: > evanm: ping? ...
8 years, 11 months ago (2012-01-25 22:04:00 UTC) #13
Evan Martin
LGTM rubber stamp On Wed, Jan 25, 2012 at 2:03 PM, Evan Martin <evan@chromium.org> wrote: ...
8 years, 11 months ago (2012-01-26 00:28:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/9117038/9003
8 years, 11 months ago (2012-01-26 00:29:13 UTC) #15
commit-bot: I haz the power
8 years, 11 months ago (2012-01-26 01:56:22 UTC) #16
Change committed as 119173

Powered by Google App Engine
This is Rietveld 408576698