Issue 9117035: Initially unmap one of the semispaces to reduce memory use at boot time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9117035: Initially unmap one of the semispaces to reduce memory use at boot time. (Closed)

Created:
8 years, 11 months ago by Erik Corry

Modified:
8 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Initially unmap one of the semispaces to reduce memory use at boot time. Committed: https://code.google.com/p/v8/source/detail?r=10491

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -16 lines)			Patch
M	src/spaces.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces.cc	View	4 chunks	+12 lines, -11 lines	1 comment	Download
M	test/cctest/test-mark-compact.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

8 years, 11 months ago (2012-01-24 15:57:36 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9117035/diff/1/src/spaces.cc
File src/spaces.cc (right):

https://chromiumcodereview.appspot.com/9117035/diff/1/src/spaces.cc#newcode1234
src/spaces.cc:1234: if (!ok) return false;
if (!Commit()) return false;

Expand Messages | Collapse Messages