Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: src/hydrogen-instructions.h

Issue 9117034: New class for Date objects: caches individual date components. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index de6800deb0b61ab43ad55bd68ca1e5616ce4b24f..c926aa65699a76cfb6d9b785e2d9920636c90686 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -179,7 +179,8 @@ class LChunkBuilder;
V(UnaryMathOperation) \
V(UnknownOSRValue) \
V(UseConst) \
- V(ValueOf)
+ V(ValueOf) \
+ V(DateField)
ulan 2012/01/25 13:08:48 Don't forget SetDateField.
rossberg 2012/01/25 15:48:37 There was no HSetDateField instruction. ;) However
#define GVN_FLAG_LIST(V) \
V(Calls) \
@@ -4510,6 +4511,26 @@ class HValueOf: public HUnaryOperation {
};
+class HDateField: public HUnaryOperation {
ulan 2012/01/25 13:08:48 This instruction has two arguments, so HBinaryOper
rossberg 2012/01/25 15:48:37 No, it's a unary instruction. The index is merely
+ public:
+ HDateField(HValue* value, int index)
+ : HUnaryOperation(value), index_(index) {
+ set_representation(Representation::Tagged());
ulan 2012/01/25 13:08:48 Is it possible to use Int32 representation and deo
rossberg 2012/01/25 15:48:37 Then I would need to implement the untagging in th
+ }
+
+ int index() const { return index_; }
+
+ virtual Representation RequiredInputRepresentation(int index) {
+ return Representation::Tagged();
+ }
+
+ DECLARE_CONCRETE_INSTRUCTION(DateField)
+
+ private:
+ int index_;
+};
+
+
class HDeleteProperty: public HBinaryOperation {
public:
HDeleteProperty(HValue* context, HValue* obj, HValue* key)
« no previous file with comments | « src/hydrogen.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | src/ia32/full-codegen-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698