Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: dart/frog/leg/scanner/class_element_parser.dart

Issue 9117033: Setup getter and setter elements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/frog_leg.dart ('k') | dart/frog/leg/scanner/listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/scanner/class_element_parser.dart
diff --git a/dart/frog/leg/scanner/class_element_parser.dart b/dart/frog/leg/scanner/class_element_parser.dart
index a6d0f0f65ac4d01760f6dd4be04c4967ad200362..f37413f170a168313dc6c97c69b5e86140f83dc7 100644
--- a/dart/frog/leg/scanner/class_element_parser.dart
+++ b/dart/frog/leg/scanner/class_element_parser.dart
@@ -30,6 +30,8 @@ class PartialClassElement extends ClassElement {
assert(listener.topLevelElements.isEmpty());
return cachedNode;
}
+
+ Token position() => beginToken;
}
class MemberListener extends NodeListener {
@@ -54,8 +56,8 @@ class MemberListener extends NodeListener {
return enclosingElement.name == name;
}
- void endMethod(Token beginToken, Token endToken) {
- super.endMethod(beginToken, endToken);
+ void endMethod(Token getOrSet, Token beginToken, Token endToken) {
+ super.endMethod(getOrSet, beginToken, endToken);
FunctionExpression method = popNode();
pushNode(null);
bool isConstructor = isConstructorName(method.name);
@@ -72,9 +74,16 @@ class MemberListener extends NodeListener {
} else {
name = methodName.asIdentifier().source;
}
- ElementKind kind = isConstructor ?
- ElementKind.GENERATIVE_CONSTRUCTOR :
- ElementKind.FUNCTION;
+ ElementKind kind = ElementKind.FUNCTION;
+ if (isConstructor) {
+ if (getOrSet !== null) {
+ recoverableError('illegal modifier', token: getOrSet);
+ }
+ kind = ElementKind.GENERATIVE_CONSTRUCTOR;
+ } else if (getOrSet !== null) {
+ kind = (getOrSet.stringValue === 'get')
+ ? ElementKind.GETTER : ElementKind.SETTER;
+ }
Element memberElement =
new PartialFunctionElement(name, beginToken, endToken,
kind, method.modifiers, enclosingElement);
« no previous file with comments | « dart/frog/leg/frog_leg.dart ('k') | dart/frog/leg/scanner/listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698