Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1791)

Unified Diff: dart/frog/leg/emitter.dart

Issue 9117033: Setup getter and setter elements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/elements/elements.dart ('k') | dart/frog/leg/frog_leg.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/emitter.dart
diff --git a/dart/frog/leg/emitter.dart b/dart/frog/leg/emitter.dart
index 81539e589086aec983f996e329eec08d6ebd96c7..9e41c810dd87225a7d53218de8dd7d419e2155a2 100644
--- a/dart/frog/leg/emitter.dart
+++ b/dart/frog/leg/emitter.dart
@@ -52,10 +52,9 @@ function(child, parent) {
String name = namer.getBailoutName(member);
buffer.add('$prototype.$name = $codeBlock;\n');
}
- } else {
+ } else if (member.kind === ElementKind.FIELD) {
// TODO(ngeoffray): Have another class generate the code for the
// fields.
- assert(member.kind === ElementKind.FIELD);
if (compiler.universe.invokedSetters.contains(member.name)) {
String setterName = namer.setterName(member.name);
buffer.add('$prototype.$setterName = function(v){\n' +
@@ -66,6 +65,9 @@ function(child, parent) {
buffer.add('$prototype.$getterName = function(){\n' +
' return this.${namer.getName(member)};\n}\n');
}
+ } else {
+ compiler.internalError('unexpected kind: "${member.kind}"',
+ element: member);
}
}
« no previous file with comments | « dart/frog/leg/elements/elements.dart ('k') | dart/frog/leg/frog_leg.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698