Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: src/d8.cc

Issue 9117028: Fix shared library build. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index bb4abb0e59ef8470c707b51b7a882d8c4e05b377..35d1a5914c5323e3ef2c5ec1221081fdb9e097b3 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -1036,9 +1036,7 @@ Handle<Value> Shell::ReadBinary(const Arguments& args) {
// We skip checking the string for UTF8 characters and use it raw as
// backing store for the external string with 8-bit characters.
BinaryResource* resource = new BinaryResource(chars, size);
- i::Handle<i::String> string(
- FACTORY->NewExternalStringFromAscii(resource));
- return Utils::ToLocal(string);
+ return String::NewExternal(resource);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698