Issue 9113079: DevTools: refactor remote debugging server to enable content_shell debugging.

Issue 9113079: DevTools: refactor remote debugging server to enable content_shell debugging. (Closed)

Created:
8 years, 11 months ago by pfeldman

Modified:
8 years, 11 months ago

Reviewers:
jam, yurys

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: refactor remote debugging server to enable content_shell debugging. BUG=97465 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119230 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119243

Patch Set 2 : Patch for landing. #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -263 lines)			Patch
M	chrome/browser/debugger/browser_list_tabcontents_provider.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/debugger/browser_list_tabcontents_provider.cc	View		3 chunks	+12 lines, -2 lines	0 comments	Download
A +	chrome/browser/debugger/frontend/devtools_discovery_page.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/debugger/frontend/devtools_discovery_page_resources.grd	View		1 chunk	+6 lines, -6 lines	0 comments	Download
D	chrome/browser/debugger/frontend/devtools_frontend.html	View		1 chunk	+0 lines, -142 lines	0 comments	Download
D	chrome/browser/debugger/frontend/devtools_frontend_resources.grd	View		1 chunk	+0 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/webui/devtools_ui.cc	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/chrome_repack_resources.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_resources.gyp	View		2 chunks	+3 lines, -29 lines	0 comments	Download
A	content/browser/debugger/DEPS	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/debugger/devtools_http_handler_impl.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/debugger/devtools_http_handler_impl.cc	View	1	10 chunks	+91 lines, -43 lines	2 comments	Download
M	content/browser/debugger/devtools_netlog_observer.cc	View		1 chunk	+7 lines, -6 lines	0 comments	Download
A	content/browser/debugger/devtools_resources.gyp	View		1 chunk	+47 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/public/browser/devtools_http_handler.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/browser/devtools_http_handler_delegate.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	tools/gritsettings/resource_ids	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

Hey guys, here is the first change that refactors remote debugging a bit in order ...

8 years, 11 months ago (2012-01-26 12:04:24 UTC) #1

jam

great, just one comment for the future https://chromiumcodereview.appspot.com/9113079/diff/4002/content/browser/debugger/devtools_http_handler_impl.cc File content/browser/debugger/devtools_http_handler_impl.cc (right): https://chromiumcodereview.appspot.com/9113079/diff/4002/content/browser/debugger/devtools_http_handler_impl.cc#newcode28 content/browser/debugger/devtools_http_handler_impl.cc:28: #include "content/public/browser/web_contents.h" ...

8 years, 11 months ago (2012-01-26 17:30:08 UTC) #3

pfeldman

8 years, 11 months ago (2012-01-26 17:34:13 UTC) #4

https://chromiumcodereview.appspot.com/9113079/diff/4002/content/browser/debu...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

https://chromiumcodereview.appspot.com/9113079/diff/4002/content/browser/debu...
content/browser/debugger/devtools_http_handler_impl.cc:28: #include
"content/public/browser/web_contents.h"
Ok, so you are saying I should revert the tab_contents -> webcontents part of
the change? I'll do it in my subsequent patch.

Expand Messages | Collapse Messages