Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: ppapi/thunk/ppb_file_ref_thunk.cc

Issue 9113044: Convert to new enter method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: PATCH DESCRIPTIONS ARE A STUPID WASTE OF TIME Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/thunk/ppb_file_io_trusted_thunk.cc ('k') | ppapi/thunk/ppb_file_system_thunk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/thunk/ppb_file_ref_thunk.cc
diff --git a/ppapi/thunk/ppb_file_ref_thunk.cc b/ppapi/thunk/ppb_file_ref_thunk.cc
index 7fdb8ac8ba6e9c9fea5cbec177e1bd8e946c28e5..8752b7fb9b79f24261ac801a36b32703f9556005 100644
--- a/ppapi/thunk/ppb_file_ref_thunk.cc
+++ b/ppapi/thunk/ppb_file_ref_thunk.cc
@@ -7,7 +7,6 @@
#include "ppapi/c/pp_completion_callback.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/c/private/ppb_file_ref_private.h"
-#include "ppapi/thunk/common.h"
#include "ppapi/thunk/enter.h"
#include "ppapi/thunk/thunk.h"
#include "ppapi/thunk/ppb_file_ref_api.h"
@@ -18,6 +17,8 @@ namespace thunk {
namespace {
+typedef EnterResource<PPB_FileRef_API> EnterFileRef;
+
PP_Resource Create(PP_Resource file_system, const char* path) {
EnterFunctionGivenResource<ResourceCreationAPI> enter(file_system, true);
if (enter.failed())
@@ -26,81 +27,78 @@ PP_Resource Create(PP_Resource file_system, const char* path) {
}
PP_Bool IsFileRef(PP_Resource resource) {
- EnterResource<PPB_FileRef_API> enter(resource, false);
+ EnterFileRef enter(resource, false);
return PP_FromBool(enter.succeeded());
}
PP_FileSystemType GetFileSystemType(PP_Resource file_ref) {
- EnterResource<PPB_FileRef_API> enter(file_ref, true);
+ EnterFileRef enter(file_ref, true);
if (enter.failed())
return PP_FILESYSTEMTYPE_INVALID;
return enter.object()->GetFileSystemType();
}
PP_Var GetName(PP_Resource file_ref) {
- EnterResource<PPB_FileRef_API> enter(file_ref, true);
+ EnterFileRef enter(file_ref, true);
if (enter.failed())
return PP_MakeUndefined();
return enter.object()->GetName();
}
PP_Var GetPath(PP_Resource file_ref) {
- EnterResource<PPB_FileRef_API> enter(file_ref, true);
+ EnterFileRef enter(file_ref, true);
if (enter.failed())
return PP_MakeUndefined();
return enter.object()->GetPath();
}
PP_Resource GetParent(PP_Resource file_ref) {
- EnterResource<PPB_FileRef_API> enter(file_ref, true);
+ EnterFileRef enter(file_ref, true);
if (enter.failed())
- return PP_ERROR_BADRESOURCE;
+ return 0;
return enter.object()->GetParent();
}
int32_t MakeDirectory(PP_Resource directory_ref,
PP_Bool make_ancestors,
PP_CompletionCallback callback) {
- EnterResource<PPB_FileRef_API> enter(directory_ref, true);
+ EnterFileRef enter(directory_ref, callback, true);
if (enter.failed())
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->MakeDirectory(make_ancestors, callback);
- return MayForceCallback(callback, result);
+ return enter.retval();
+ return enter.SetResult(enter.object()->MakeDirectory(make_ancestors,
+ callback));
}
int32_t Touch(PP_Resource file_ref,
PP_Time last_access_time,
PP_Time last_modified_time,
PP_CompletionCallback callback) {
- EnterResource<PPB_FileRef_API> enter(file_ref, true);
+ EnterFileRef enter(file_ref, callback, true);
if (enter.failed())
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->Touch(last_access_time, last_modified_time,
- callback);
- return MayForceCallback(callback, result);
+ return enter.retval();
+ return enter.SetResult(enter.object()->Touch(
+ last_access_time, last_modified_time, callback));
}
int32_t Delete(PP_Resource file_ref,
PP_CompletionCallback callback) {
- EnterResource<PPB_FileRef_API> enter(file_ref, true);
+ EnterFileRef enter(file_ref, callback, true);
if (enter.failed())
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->Delete(callback);
- return MayForceCallback(callback, result);
+ return enter.retval();
+ return enter.SetResult(enter.object()->Delete(callback));
}
int32_t Rename(PP_Resource file_ref,
PP_Resource new_file_ref,
PP_CompletionCallback callback) {
- EnterResource<PPB_FileRef_API> enter(file_ref, true);
+ EnterFileRef enter(file_ref, callback, true);
if (enter.failed())
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->Rename(new_file_ref, callback);
- return MayForceCallback(callback, result);
+ return enter.retval();
+ return enter.SetResult(enter.object()->Rename(new_file_ref, callback));
}
PP_Var GetAbsolutePath(PP_Resource file_ref) {
- EnterResource<PPB_FileRef_API> enter(file_ref, true);
+ EnterFileRef enter(file_ref, true);
if (enter.failed())
return PP_MakeUndefined();
return enter.object()->GetAbsolutePath();
« no previous file with comments | « ppapi/thunk/ppb_file_io_trusted_thunk.cc ('k') | ppapi/thunk/ppb_file_system_thunk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698