Issue 9111036: Promote double arrays to FAST_ELEMENT that use generic KeyedLoadIC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9111036: Promote double arrays to FAST_ELEMENT that use generic KeyedLoadIC (Closed)

Created:
8 years, 11 months ago by danno

Modified:
8 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Promote double arrays to FAST_ELEMENT that use generic KeyedLoadIC Committed: https://code.google.com/p/v8/source/detail?r=10652

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	src/ic.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
	M	src/runtime.cc	View	1	1 chunk	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 10 months ago (2012-02-08 14:56:28 UTC) #2

LGTM.

http://codereview.chromium.org/9111036/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/9111036/diff/1/src/runtime.cc#newcode4191
src/runtime.cc:4191: // proactively avoid excessive boxing, proactively
transition
nit: one "proactively" per line is enough.

Expand Messages | Collapse Messages