Added API Dart_PostCMessage for posting a Dart_CMessage structure

Implemented encoding af a Dart_CMessage structure into a Dart message. Currently supported types are:

  Boolean
  Smi
  Double
  String
  Array

The encoding uses the upper bits of the Dart_CObject type field for "marking" already written objects with their object id for generating backward references. After serialization these mark are removed.

Added the API Dart_PostCMessage for encoding and posting a Dart_CMessage structure.

Removed the API Dart_PostIntArray and used Dart_PostCMessage instead.

R=asive@google.com,turnidge@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3947

[Søren Gjesse, 2012-01-31 16:35:44]

This is based on https://chromiumcodereview.appspot.com/9159066/.

[Søren Gjesse, 2012-01-31 20:26:16]

Resending as I mistyped Sivas mail address.

[siva, 2012-02-01 01:01:33]

https://chromiumcodereview.appspot.com/9104041/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/9104041/diff/1/runtime/include/dart_ap...
runtime/include/dart_api.h:1449: // TODO(sgjesse): Return the length of the
encoded message.
Instead of an API call to encode a CMessage would it make sense to have an API
call similar to Dart_PostIntArray for Posting a CMessage object. (The CMessage
object will also take care of the int array case).

That way we don't have to get back a stream and then have another call to post
that stream into a port, deal with the life cycle of the stream etc.


Once this works Dart_PostIntArray could be deleted and all the calls replaced
with Dart_PostCMessage(...)

https://chromiumcodereview.appspot.com/9104041/diff/1/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/9104041/diff/1/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:2519: }
Ditto comment regarding the need for this in the API

[Søren Gjesse, 2012-02-02 14:25:58]

Added the Dart_PostCMessage API and removed Dart_PostIntArray.

PTAL

http://codereview.chromium.org/9104041/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/9104041/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:1449: // TODO(sgjesse): Return the length of the
encoded message.
On 2012/02/01 01:01:33, asiva wrote:
> Instead of an API call to encode a CMessage would it make sense to have an API
> call similar to Dart_PostIntArray for Posting a CMessage object. (The CMessage
> object will also take care of the int array case).
> 
> That way we don't have to get back a stream and then have another call to post
> that stream into a port, deal with the life cycle of the stream etc.
> 
> 
> Once this works Dart_PostIntArray could be deleted and all the calls replaced
> with Dart_PostCMessage(...)

Done.

http://codereview.chromium.org/9104041/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/9104041/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:2519: }
On 2012/02/01 01:01:33, asiva wrote:
> Ditto comment regarding the need for this in the API

Done.

[Søren Gjesse, 2012-02-03 07:42:26]

Updated the subject and description of this change to reflect it's changed
content.

[siva, 2012-02-04 02:51:17]

lgtm once issue regarding need for Dart_CMessage is resolved.

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/dartutils.cc#new...
runtime/bin/dartutils.cc:241: return Dart_PostCMessage(port_id, &message);
I have the same question that I had in the other CL, does
Dart_CMessage help in some way?

I was wondering if Dart_PostCMessage could take a Dart_CObject* parameter
directly.

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/dartutils.cc#new...
runtime/bin/dartutils.cc:249: ASSERT(min <= value && value < max);
Would this work on a 64 bit system where value could be larger than the range
you have.

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:45: void _multiplex(int event_mask) {
Are you stating that we will only have to handle one event here and will not
have a need later to expand it to handle an array of events?

[Søren Gjesse, 2012-02-06 15:35:49]

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/dartutils.cc#new...
runtime/bin/dartutils.cc:241: return Dart_PostCMessage(port_id, &message);
On 2012/02/04 02:51:17, asiva wrote:
> I have the same question that I had in the other CL, does
> Dart_CMessage help in some way?
> 
> I was wondering if Dart_PostCMessage could take a Dart_CObject* parameter
> directly.

Yes, Dart_CMessage is gone.

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/dartutils.cc#new...
runtime/bin/dartutils.cc:249: ASSERT(min <= value && value < max);
On 2012/02/04 02:51:17, asiva wrote:
> Would this work on a 64 bit system where value could be larger than the range
> you have.

Changed the method to PostInt32 and with int32_t parameter type.

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

http://codereview.chromium.org/9104041/diff/6002/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:45: void _multiplex(int event_mask) {
On 2012/02/04 02:51:17, asiva wrote:
> Are you stating that we will only have to handle one event here and will not
> have a need later to expand it to handle an array of events?

Not necessarily. Previously we received an array but only ever looked at element
0. If we want to post several events from the eventhandler at some point we can
just change the message to become an array again.

[siva, 2012-02-06 18:55:12]

https://chromiumcodereview.appspot.com/9104041/diff/7002/runtime/include/dart...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/9104041/diff/7002/runtime/include/dart...
runtime/include/dart_api.h:1429: * Dart_CObject structures rooted in message
should not be accessed,
rooted in 'message' or rooted in 'root', we could change the parameter name to
'message' if you want.

https://chromiumcodereview.appspot.com/9104041/diff/7002/runtime/include/dart...
runtime/include/dart_api.h:1430: * as the message generation will make temporaly
modification to the
'temporary modifications to the'