Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: chrome/browser/feedback/feedback_data.h

Issue 9104030: Include a timestamp with and add a keyboard shortcut for Feedback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FEEDBACK_FEEDBACK_DATA_H_ 5 #ifndef CHROME_BROWSER_FEEDBACK_FEEDBACK_DATA_H_
6 #define CHROME_BROWSER_FEEDBACK_FEEDBACK_DATA_H_ 6 #define CHROME_BROWSER_FEEDBACK_FEEDBACK_DATA_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 16 matching lines...) Expand all
27 void UpdateData(Profile* profile, 27 void UpdateData(Profile* profile,
28 const std::string& target_tab_url, 28 const std::string& target_tab_url,
29 const std::string& category_tag, 29 const std::string& category_tag,
30 const std::string& page_url, 30 const std::string& page_url,
31 const std::string& description, 31 const std::string& description,
32 ScreenshotDataPtr image 32 ScreenshotDataPtr image
33 #if defined(OS_CHROMEOS) 33 #if defined(OS_CHROMEOS)
34 , const std::string& user_email 34 , const std::string& user_email
35 , const bool send_sys_info 35 , const bool send_sys_info
36 , const bool sent_report 36 , const bool sent_report
37 , const std::string& timestamp
zel 2012/01/31 16:38:03 string? why don't you pass this as base::Time and
rkc 2012/01/31 18:16:45 The reason we are converting the time to a string
37 #endif 38 #endif
38 ); 39 );
39 40
40 #if defined(OS_CHROMEOS) 41 #if defined(OS_CHROMEOS)
41 void SyslogsComplete(chromeos::system::LogDictionaryType* logs, 42 void SyslogsComplete(chromeos::system::LogDictionaryType* logs,
42 std::string* zip_content); 43 std::string* zip_content);
43 #endif 44 #endif
44 45
45 const std::string& target_tab_url() const { return target_tab_url_; } 46 const std::string& target_tab_url() const { return target_tab_url_; }
46 47
(...skipping 20 matching lines...) Expand all
67 std::string page_url_; 68 std::string page_url_;
68 std::string description_; 69 std::string description_;
69 ScreenshotDataPtr image_; 70 ScreenshotDataPtr image_;
70 71
71 #if defined(OS_CHROMEOS) 72 #if defined(OS_CHROMEOS)
72 // Chromeos specific values for SendReport. 73 // Chromeos specific values for SendReport.
73 std::string user_email_; 74 std::string user_email_;
74 chromeos::system::LogDictionaryType* sys_info_; 75 chromeos::system::LogDictionaryType* sys_info_;
75 // Content of the compressed system logs. 76 // Content of the compressed system logs.
76 std::string* zip_content_; 77 std::string* zip_content_;
78 std::string timestamp_;
77 // NOTE: Extra boolean sent_report_ is required because callback may 79 // NOTE: Extra boolean sent_report_ is required because callback may
78 // occur before or after we call SendReport(). 80 // occur before or after we call SendReport().
79 bool sent_report_; 81 bool sent_report_;
80 // Flag to indicate to SyslogsComplete that it should send the report 82 // Flag to indicate to SyslogsComplete that it should send the report
81 bool send_sys_info_; 83 bool send_sys_info_;
82 #endif 84 #endif
83 }; 85 };
84 86
85 #endif // CHROME_BROWSER_FEEDBACK_FEEDBACK_DATA_H_ 87 #endif // CHROME_BROWSER_FEEDBACK_FEEDBACK_DATA_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/feedback/feedback_data.cc » ('j') | chrome/browser/ui/webui/feedback_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698