Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: frog/leg/resolver.dart

Issue 9086010: closure calls (just the invocation part). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add test file. Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/leg/resolver.dart
diff --git a/frog/leg/resolver.dart b/frog/leg/resolver.dart
index 2109c14cd1ba7a25b8a2ee56e287026a3982b7ea..822863c06707b4d0b19bc8f9d7662e5e700ba4f4 100644
--- a/frog/leg/resolver.dart
+++ b/frog/leg/resolver.dart
@@ -314,7 +314,15 @@ class FullResolverVisitor extends ResolverVisitor {
Element receiver = visit(node.receiver);
visit(node.argumentsNode);
- Identifier selector = node.selector;
+ Identifier selector = node.selector.asIdentifier();
+ if (selector === null) {
kasperl 2012/01/05 07:01:52 Could we have a tester on node.selector instead? S
floitsch 2012/01/05 12:18:38 done. except in the resolver since the test needs
+ // Closure call.
ngeoffray 2012/01/05 14:05:46 Closure call -> We're calling a closure returned f
floitsch 2012/01/24 13:28:37 Done.
+ assert(node.selector.asExpression() !== null);
+ assert(receiver === null);
+ visit(node.selector);
+ return null;
+ }
+
SourceString name = selector.source;
// No need to assign an element for a logical operation.
if (isLogicalOperator(selector)) return null;

Powered by Google App Engine
This is Rietveld 408576698