Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6119)

Unified Diff: chrome/browser/ui/views/frame/browser_frame_aura.cc

Issue 9021046: Pass const gfx::Rect& as the first parameter to FillRect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_frame_aura.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame_aura.cc b/chrome/browser/ui/views/frame/browser_frame_aura.cc
index 3546cb4d9a40f1a31b70f59f5c99b2ee99c7215b..0392cc750e9a24d1fc12cd748ba036a195ff2e97 100644
--- a/chrome/browser/ui/views/frame/browser_frame_aura.cc
+++ b/chrome/browser/ui/views/frame/browser_frame_aura.cc
@@ -82,9 +82,8 @@ void ToolbarBackground::Paint(gfx::Canvas* canvas, views::View* view) const {
h));
canvas->GetSkCanvas()->drawARGB(0, 255, 255, 255, SkXfermode::kClear_Mode);
- SkColor theme_toolbar_color = tp->GetColor(ThemeService::COLOR_TOOLBAR);
- canvas->FillRect(theme_toolbar_color,
- gfx::Rect(x, bottom_y, w, bottom_edge_height));
+ canvas->FillRect(gfx::Rect(x, bottom_y, w, bottom_edge_height),
+ tp->GetColor(ThemeService::COLOR_TOOLBAR));
// Tile the toolbar image starting at the frame edge on the left and where the
// horizontal tabstrip is (or would be) on the top.
@@ -149,13 +148,12 @@ void ToolbarBackground::Paint(gfx::Canvas* canvas, views::View* view) const {
bottom_edge_height, false);
// Draw the content/toolbar separator.
- canvas->FillRect(
- ResourceBundle::toolbar_separator_color,
- gfx::Rect(
- x + views::NonClientFrameView::kClientEdgeThickness,
- toolbar_bounds.bottom() - views::NonClientFrameView::kClientEdgeThickness,
- w - (2 * views::NonClientFrameView::kClientEdgeThickness),
- views::NonClientFrameView::kClientEdgeThickness));
+ canvas->FillRect(gfx::Rect(
+ x + views::NonClientFrameView::kClientEdgeThickness,
+ toolbar_bounds.bottom() - views::NonClientFrameView::kClientEdgeThickness,
+ w - (2 * views::NonClientFrameView::kClientEdgeThickness),
+ views::NonClientFrameView::kClientEdgeThickness),
+ ResourceBundle::toolbar_separator_color);
}
////////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698