Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/tab_contents/thumbnail_generator_unittest.cc

Issue 9021046: Pass const gfx::Rect& as the first parameter to FillRect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ntp_background_util.cc ('k') | chrome/browser/ui/gtk/gtk_theme_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/thumbnail_generator_unittest.cc
diff --git a/chrome/browser/tab_contents/thumbnail_generator_unittest.cc b/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
index 921b942c2021f80d1949b8f2fb42de42336c035d..885577a2e8b7a99e54521a5d73c4903c90c9eccb 100644
--- a/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
+++ b/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
@@ -212,7 +212,7 @@ TEST_F(ThumbnailGeneratorSimpleTest, CalculateBoringScore_SingleColor) {
const gfx::Size kSize(20, 10);
gfx::CanvasSkia canvas(kSize, true);
// Fill all pixesl in black.
- canvas.FillRect(kBlack, gfx::Rect(gfx::Point(), kSize));
+ canvas.FillRect(gfx::Rect(gfx::Point(), kSize), kBlack);
SkBitmap bitmap =
skia::GetTopDevice(*canvas.sk_canvas())->accessBitmap(false);
@@ -227,9 +227,9 @@ TEST_F(ThumbnailGeneratorSimpleTest, CalculateBoringScore_TwoColors) {
gfx::CanvasSkia canvas(kSize, true);
// Fill all pixesl in black.
- canvas.FillRect(kBlack, gfx::Rect(gfx::Point(), kSize));
+ canvas.FillRect(gfx::Rect(gfx::Point(), kSize), kBlack);
// Fill the left half pixels in white.
- canvas.FillRect(kWhite, gfx::Rect(0, 0, kSize.width() / 2, kSize.height()));
+ canvas.FillRect(gfx::Rect(0, 0, kSize.width() / 2, kSize.height()), kWhite);
SkBitmap bitmap =
skia::GetTopDevice(*canvas.sk_canvas())->accessBitmap(false);
« no previous file with comments | « chrome/browser/ntp_background_util.cc ('k') | chrome/browser/ui/gtk/gtk_theme_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698