Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Side by Side Diff: ui/gfx/canvas_skia.h

Issue 9021046: Pass const gfx::Rect& as the first parameter to FillRect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/gfx/canvas.h ('k') | ui/gfx/canvas_skia.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GFX_CANVAS_SKIA_H_ 5 #ifndef UI_GFX_CANVAS_SKIA_H_
6 #define UI_GFX_CANVAS_SKIA_H_ 6 #define UI_GFX_CANVAS_SKIA_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 104
105 // Overridden from Canvas: 105 // Overridden from Canvas:
106 virtual void Save() OVERRIDE; 106 virtual void Save() OVERRIDE;
107 virtual void SaveLayerAlpha(uint8 alpha) OVERRIDE; 107 virtual void SaveLayerAlpha(uint8 alpha) OVERRIDE;
108 virtual void SaveLayerAlpha(uint8 alpha, 108 virtual void SaveLayerAlpha(uint8 alpha,
109 const gfx::Rect& layer_bounds) OVERRIDE; 109 const gfx::Rect& layer_bounds) OVERRIDE;
110 virtual void Restore() OVERRIDE; 110 virtual void Restore() OVERRIDE;
111 virtual bool ClipRect(const gfx::Rect& rect) OVERRIDE; 111 virtual bool ClipRect(const gfx::Rect& rect) OVERRIDE;
112 virtual void Translate(const gfx::Point& point) OVERRIDE; 112 virtual void Translate(const gfx::Point& point) OVERRIDE;
113 virtual void Scale(int x_scale, int y_scale) OVERRIDE; 113 virtual void Scale(int x_scale, int y_scale) OVERRIDE;
114 virtual void FillRect(const SkColor& color, const gfx::Rect& rect) OVERRIDE; 114 virtual void FillRect(const gfx::Rect& rect, const SkColor& color) OVERRIDE;
115 virtual void FillRect(const SkColor& color, 115 virtual void FillRect(const gfx::Rect& rect,
116 const gfx::Rect& rect, 116 const SkColor& color,
117 SkXfermode::Mode mode) OVERRIDE; 117 SkXfermode::Mode mode) OVERRIDE;
118 virtual void FillRect(const gfx::Brush* brush, 118 virtual void FillRect(const gfx::Rect& rect,
119 const gfx::Rect& rect) OVERRIDE; 119 const gfx::Brush* brush) OVERRIDE;
120 virtual void DrawRect(const gfx::Rect& rect, const SkColor& color) OVERRIDE; 120 virtual void DrawRect(const gfx::Rect& rect, const SkColor& color) OVERRIDE;
121 virtual void DrawRect(const gfx::Rect& rect, 121 virtual void DrawRect(const gfx::Rect& rect,
122 const SkColor& color, 122 const SkColor& color,
123 SkXfermode::Mode mode) OVERRIDE; 123 SkXfermode::Mode mode) OVERRIDE;
124 virtual void DrawRect(const gfx::Rect& rect, const SkPaint& paint) OVERRIDE; 124 virtual void DrawRect(const gfx::Rect& rect, const SkPaint& paint) OVERRIDE;
125 virtual void DrawLineInt(const SkColor& color, 125 virtual void DrawLineInt(const SkColor& color,
126 int x1, int y1, 126 int x1, int y1,
127 int x2, int y2) OVERRIDE; 127 int x2, int y2) OVERRIDE;
128 virtual void DrawBitmapInt(const SkBitmap& bitmap, int x, int y) OVERRIDE; 128 virtual void DrawBitmapInt(const SkBitmap& bitmap, int x, int y) OVERRIDE;
129 virtual void DrawBitmapInt(const SkBitmap& bitmap, 129 virtual void DrawBitmapInt(const SkBitmap& bitmap,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 198
199 scoped_ptr<skia::PlatformCanvas> owned_canvas_; 199 scoped_ptr<skia::PlatformCanvas> owned_canvas_;
200 SkCanvas* canvas_; 200 SkCanvas* canvas_;
201 201
202 DISALLOW_COPY_AND_ASSIGN(CanvasSkia); 202 DISALLOW_COPY_AND_ASSIGN(CanvasSkia);
203 }; 203 };
204 204
205 } // namespace gfx 205 } // namespace gfx
206 206
207 #endif // UI_GFX_CANVAS_SKIA_H_ 207 #endif // UI_GFX_CANVAS_SKIA_H_
OLDNEW
« no previous file with comments | « ui/gfx/canvas.h ('k') | ui/gfx/canvas_skia.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698