Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java

Issue 900443003: Add support for ContentViewCore helpers on Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renaming is apparently difficult for me... Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
index 9a7774bfed99352f16a53cb1d211b2f0d5d1c2b1..ca914340ef5058bd86f6a7c75a810b28f472eb48 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
@@ -47,6 +47,20 @@ public interface TabObserver {
void onContentChanged(Tab tab);
/**
+ * Called when a {@link ContentViewCore} overlay is attached to {@code tab}.
+ * @param tab The notifying {@link Tab}.
+ * @param content The {@link ContentViewCore} being added.
+ */
+ void onOverlayContentViewCoreAdded(Tab tab, ContentViewCore content);
+
+ /**
+ * Called when a {@link ContentViewCore} overlay is detached from {@code tab}.
+ * @param tab The notifying {@link Tab}.
+ * @param content The {@link ContentViewCore} being removed.
+ */
+ void onOverlayContentViewCoreRemoved(Tab tab, ContentViewCore content);
+
+ /**
* Called when loadUrl is triggered on a a {@link Tab}.
* @param tab The notifying {@link Tab}.
* @param url The url that is being loaded.
@@ -260,6 +274,11 @@ public interface TabObserver {
*/
public void onDidDetachInterstitialPage(Tab tab);
+ /**
+ * Called when a navigation is started to a pending entry.
+ * @param tab The notifying {@link Tab}.
+ * @param url The url being navigated to.
+ */
public void onDidStartNavigationToPendingEntry(Tab tab, String url);
/**
@@ -269,6 +288,15 @@ public interface TabObserver {
*/
public void onBackgroundColorChanged(Tab tab, int color);
+ /**
+ * Called when a {@link WebContents} object has been created.
+ * @param tab The notifying {@link Tab}.
+ * @param sourceWebContents The {@link WebContents} that triggered the creation.
+ * @param openerRenderFrameId The opener render frame id.
+ * @param frameName The name of the frame.
+ * @param targetUrl The target url.
+ * @param newWebContents The newly created {@link WebContents}.
+ */
public void webContentsCreated(Tab tab, WebContents sourceWebContents, long openerRenderFrameId,
String frameName, String targetUrl, WebContents newWebContents);
}

Powered by Google App Engine
This is Rietveld 408576698