content/browser/android/content_view_core_impl.cc - Issue 900443003: Add support for ContentViewCore helpers on Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 900443003: Add support for ContentViewCore helpers on Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed javadocs, moved notification to before helper is removed. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 5fd29f12512c4cd97d3e5dbdf8bf6b49f29d14b3..0b864f11fe94454e68ce75d9741698d3f14a8cd1 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -256,6 +256,8 @@ ContentViewCoreImpl::ContentViewCoreImpl(

}

ContentViewCoreImpl::~ContentViewCoreImpl() {

+ root_layer_->RemoveFromParent();

JNIEnv* env = base::android::AttachCurrentThread();

ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);

java_ref_.reset();