chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java - Issue 900443003: Add support for ContentViewCore helpers on Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

Issue 900443003: Add support for ContentViewCore helpers on Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed javadocs, moved notification to before helper is removed. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

index 80f1eb219dc54146286725456158c47d5c3ecb4d..3bb84b924022afefd35b16207bdbc0b97040e3bf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

@@ -6,6 +6,7 @@ package org.chromium.chrome.browser;

import android.view.ContextMenu;

+import org.chromium.content.browser.ContentViewCore;

import org.chromium.content_public.browser.WebContents;

/**

@@ -29,6 +30,12 @@ public class EmptyTabObserver implements TabObserver {

public void onContentChanged(Tab tab) { }

@Override

+ public void onHelperContentAdded(Tab tab, ContentViewCore content) { }

+ @Override

+ public void onHelperContentRemoved(Tab tab, ContentViewCore content) { }

+ @Override

public void onLoadUrl(Tab tab, String url, int loadType) { }

@Override

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('J')