[Cleanup] Const-correct the profile() method for the EasyUnlockService

chrome/test/base/testing_profile.cc

Index: chrome/test/base/testing_profile.cc
diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc
index 3c2a90fe73855fe22e192c9b6573a493bbd2f634..7aaf80224611343c88e763a5a36a8ae82c19ba84 100644
--- a/chrome/test/base/testing_profile.cc
+++ b/chrome/test/base/testing_profile.cc
@@ -817,6 +817,11 @@ if (!policy_service_) {
 }
 
 PrefService* TestingProfile::GetPrefs() {
+  return const_cast<PrefService*>(
+      static_cast<const TestingProfile*>(this)->GetPrefs());

[sky, 2015/02/05 17:00:58]

Shouldn't this be const_cast here too? I would have inlined this one, but it's
up to you.

[Ilya Sherman, 2015/02/05 21:24:58]

You only need to const_cast in order to drop a const; it's fine to static_cast
when adding a const.  I'm fine with inlining this one, though -- switched to
that.

+}
+
+const PrefService* TestingProfile::GetPrefs() const {
   DCHECK(prefs_);
   return prefs_.get();
 }