[Cleanup] Const-correct the profile() method for the EasyUnlockService

chrome/test/base/testing_profile.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/testing_profile.h"
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/message_loop/message_loop_proxy.h"
@@ skipping 799 matching lines @@
   }
   profile_policy_connector_.reset(new policy::ProfilePolicyConnector());
   profile_policy_connector_->InitForTesting(policy_service_.Pass());
   policy::ProfilePolicyConnectorFactory::GetInstance()->SetServiceForTesting(
       this, profile_policy_connector_.get());
   CHECK_EQ(profile_policy_connector_.get(),
            policy::ProfilePolicyConnectorFactory::GetForProfile(this));
 }
 
 PrefService* TestingProfile::GetPrefs() {
+  return const_cast<PrefService*>(
+      static_cast<const TestingProfile*>(this)->GetPrefs());

[sky, 2015/02/05 17:00:58]

Shouldn't this be const_cast here too? I would have inlined this one, but it's
up to you.

[Ilya Sherman, 2015/02/05 21:24:58]

You only need to const_cast in order to drop a const; it's fine to static_cast
when adding a const.  I'm fine with inlining this one, though -- switched to
that.

+}
+
+const PrefService* TestingProfile::GetPrefs() const {
   DCHECK(prefs_);
   return prefs_.get();
 }
 
 DownloadManagerDelegate* TestingProfile::GetDownloadManagerDelegate() {
   return NULL;
 }
 
 net::URLRequestContextGetter* TestingProfile::GetRequestContext() {
   return GetDefaultStoragePartition(this)->GetURLRequestContext();
@@ skipping 253 matching lines @@
 #if defined(ENABLE_EXTENSIONS)
                             extension_policy_,
 #endif
                             pref_service_.Pass(),
                             original_profile,
                             guest_session_,
                             supervised_user_id_,
                             policy_service_.Pass(),
                             testing_factories_);
 }