[Cleanup] Const-correct the profile() method for the EasyUnlockService

[Cleanup] Const-correct the profile() method for the EasyUnlockService

BUG=none
TEST=none
R=rogerta@chromium.org, sky@chromium.org

Committed: https://crrev.com/91ffd8b5c50310a5b6bdcf55165bbca92247c112
Cr-Commit-Position: refs/heads/master@{#317014}

[Ilya Sherman, 2015-02-05 03:11:13]

sky@chromium.org for //chrome/test and //chrome/browser/ui
rogerta@chromium.org for the rest (//chrome/browser/profiles and
//chrome/browser/signin)

[sky, 2015-02-05 17:00:58]

https://chromiumcodereview.appspot.com/898003002/diff/1/chrome/browser/ui/app...
File chrome/browser/ui/app_list/test/fake_profile.cc (right):

https://chromiumcodereview.appspot.com/898003002/diff/1/chrome/browser/ui/app...
chrome/browser/ui/app_list/test/fake_profile.cc:124: return NULL;
nullptr?

https://chromiumcodereview.appspot.com/898003002/diff/1/chrome/test/base/test...
File chrome/test/base/testing_profile.cc (right):

https://chromiumcodereview.appspot.com/898003002/diff/1/chrome/test/base/test...
chrome/test/base/testing_profile.cc:821: static_cast<const
TestingProfile*>(this)->GetPrefs());
Shouldn't this be const_cast here too? I would have inlined this one, but it's
up to you.

[Ilya Sherman, 2015-02-05 21:24:58]

https://chromiumcodereview.appspot.com/898003002/diff/1/chrome/browser/ui/app...
File chrome/browser/ui/app_list/test/fake_profile.cc (right):

https://chromiumcodereview.appspot.com/898003002/diff/1/chrome/browser/ui/app...
chrome/browser/ui/app_list/test/fake_profile.cc:124: return NULL;
On 2015/02/05 17:00:58, sky wrote:
> nullptr?

Done.  Also replaced a bunch of other NULLs with nullptr in this file.

https://chromiumcodereview.appspot.com/898003002/diff/1/chrome/test/base/test...
File chrome/test/base/testing_profile.cc (right):

https://chromiumcodereview.appspot.com/898003002/diff/1/chrome/test/base/test...
chrome/test/base/testing_profile.cc:821: static_cast<const
TestingProfile*>(this)->GetPrefs());
On 2015/02/05 17:00:58, sky wrote:
> Shouldn't this be const_cast here too? I would have inlined this one, but it's
> up to you.

You only need to const_cast in order to drop a const; it's fine to static_cast
when adding a const.  I'm fine with inlining this one, though -- switched to
that.

[sky, 2015-02-06 01:02:07]

LGTM

[Ilya Sherman, 2015-02-10 04:24:18]

Roger, friendly ping now that your hackweek has concluded :)

[Roger Tawa OOO till Jul 10th, 2015-02-11 18:08:04]

lgtm

Sorry for delay Ilya.

[Ilya Sherman, 2015-02-11 18:56:43]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2015-02-11 18:57:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898003002/20001

[commit-bot: I haz the power, 2015-02-11 19:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-11 19:22:23]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ilya Sherman, 2015-02-11 22:43:40]

New patchsets have been uploaded after l-g-t-m from
sky@chromium.org,rogerta@chromium.org

[Ilya Sherman, 2015-02-12 00:08:36]

I hit a conflict after rebasing that required editing a bunch more files.  There
are only two files that were changed beyond trivial additions of const:

Roger, please take a second look at //chrome/browser/profiles/profile_impl.cc

Xiyuan, PTAL at //chrome/browser/chromeos/profiles/profile_helper.*

[Ilya Sherman, 2015-02-19 07:03:41]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2015-02-19 07:05:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898003002/60001

[commit-bot: I haz the power, 2015-02-19 07:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 07:08:53]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ilya Sherman, 2015-02-19 07:43:22]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2015-02-19 07:43:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898003002/80001

[commit-bot: I haz the power, 2015-02-19 08:52:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-19 08:53:28]

Patchset 5 (id:??) landed as
https://crrev.com/91ffd8b5c50310a5b6bdcf55165bbca92247c112
Cr-Commit-Position: refs/heads/master@{#317014}