sdk/lib/async/stream_impl.dart - Issue 896793002: Avoid crashing when a closed StreamIterator is cancelled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/stream_impl.dart

Issue 896793002: Avoid crashing when a closed StreamIterator is cancelled (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Follow Lasse's suggestion Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/async/stream_impl.dart

diff --git a/sdk/lib/async/stream_impl.dart b/sdk/lib/async/stream_impl.dart

index 394e1c6a7c72b51b25fc7df35554941a94e2e2e5..3f77294619a6e3d3b1e23f7794fc6b51e8700e95 100644

--- a/sdk/lib/async/stream_impl.dart

+++ b/sdk/lib/async/stream_impl.dart

@@ -1029,6 +1029,7 @@ class _StreamIteratorImpl<T> implements StreamIterator<T> {

Future cancel() {

StreamSubscription subscription = _subscription;

+ if (subscription == null) return null;

if (_state == _STATE_MOVING) {

_Future<bool> hasNext = _futureOrPrefetch;

_clear();

« no previous file with comments | « no previous file | tests/lib/async/stream_iterator_double_cancel_test.dart » ('j') | no next file with comments »