Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 893973005: Arg parsing tests (Closed)

Created:
5 years, 10 months ago by pquitslund
Modified:
5 years, 10 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/cli_util.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed coveralls script #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M pubspec.yaml View 1 chunk +2 lines, -0 lines 0 comments Download
A test/cli_util_test.dart View 1 chunk +21 lines, -0 lines 2 comments Download
M tool/travis.sh View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 10 months ago (2015-02-04 03:37:41 UTC) #2
devoncarew
lgtm https://chromiumcodereview.appspot.com/893973005/diff/20001/test/cli_util_test.dart File test/cli_util_test.dart (right): https://chromiumcodereview.appspot.com/893973005/diff/20001/test/cli_util_test.dart#newcode18 test/cli_util_test.dart:18: groupSep = ' | '; Curious, why are ...
5 years, 10 months ago (2015-02-04 05:09:33 UTC) #3
pquitslund
Thanks! https://chromiumcodereview.appspot.com/893973005/diff/20001/test/cli_util_test.dart File test/cli_util_test.dart (right): https://chromiumcodereview.appspot.com/893973005/diff/20001/test/cli_util_test.dart#newcode18 test/cli_util_test.dart:18: groupSep = ' | '; On 2015/02/04 05:09:33, ...
5 years, 10 months ago (2015-02-04 05:27:29 UTC) #4
pquitslund
5 years, 10 months ago (2015-02-04 05:27:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2f84d68f6e718d5ccd98c12bb51c283fed12aa6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698