Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 8932004: Implement target cache for constructor calls. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Vyacheslav Egorov. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 Generate_DebugBreakCallHelper(masm, ecx.bit(), 0, false); 221 Generate_DebugBreakCallHelper(masm, ecx.bit(), 0, false);
222 } 222 }
223 223
224 224
225 void Debug::GenerateConstructCallDebugBreak(MacroAssembler* masm) { 225 void Debug::GenerateConstructCallDebugBreak(MacroAssembler* masm) {
226 // Register state just before return from JS function (from codegen-ia32.cc). 226 // Register state just before return from JS function (from codegen-ia32.cc).
227 // eax is the actual number of arguments not encoded as a smi see comment 227 // eax is the actual number of arguments not encoded as a smi see comment
228 // above IC call. 228 // above IC call.
229 // ----------- S t a t e ------------- 229 // ----------- S t a t e -------------
230 // -- eax: number of arguments (not smi) 230 // -- eax: number of arguments (not smi)
231 // -- ebx: cache cell for call target
231 // -- edi: constructor function 232 // -- edi: constructor function
232 // ----------------------------------- 233 // -----------------------------------
233 // The number of arguments in eax is not smi encoded. 234 // The number of arguments in eax is not smi encoded.
234 Generate_DebugBreakCallHelper(masm, edi.bit(), eax.bit(), false); 235 Generate_DebugBreakCallHelper(masm, ebx.bit() | edi.bit(), eax.bit(), false);
235 } 236 }
236 237
237 238
238 void Debug::GenerateReturnDebugBreak(MacroAssembler* masm) { 239 void Debug::GenerateReturnDebugBreak(MacroAssembler* masm) {
239 // Register state just before return from JS function (from codegen-ia32.cc). 240 // Register state just before return from JS function (from codegen-ia32.cc).
240 // ----------- S t a t e ------------- 241 // ----------- S t a t e -------------
241 // -- eax: return value 242 // -- eax: return value
242 // ----------------------------------- 243 // -----------------------------------
243 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, true); 244 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, true);
244 } 245 }
245 246
246 247
247 void Debug::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) { 248 void Debug::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) {
248 // Register state for stub CallFunction (from CallFunctionStub in ic-ia32.cc). 249 // Register state for CallFunctionStub (from code-stubs-ia32.cc).
249 // ----------- S t a t e ------------- 250 // ----------- S t a t e -------------
251 // -- ebx: cache cell for call target
250 // -- edi: function 252 // -- edi: function
251 // ----------------------------------- 253 // -----------------------------------
252 Generate_DebugBreakCallHelper(masm, edi.bit(), 0, false); 254 Generate_DebugBreakCallHelper(masm, ebx.bit() | edi.bit(), 0, false);
253 } 255 }
254 256
255 257
256 void Debug::GenerateSlot(MacroAssembler* masm) { 258 void Debug::GenerateSlot(MacroAssembler* masm) {
257 // Generate enough nop's to make space for a call instruction. 259 // Generate enough nop's to make space for a call instruction.
258 Label check_codesize; 260 Label check_codesize;
259 __ bind(&check_codesize); 261 __ bind(&check_codesize);
260 __ RecordDebugBreakSlot(); 262 __ RecordDebugBreakSlot();
261 __ Nop(Assembler::kDebugBreakSlotLength); 263 __ Nop(Assembler::kDebugBreakSlotLength);
262 ASSERT_EQ(Assembler::kDebugBreakSlotLength, 264 ASSERT_EQ(Assembler::kDebugBreakSlotLength,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 304
303 const bool Debug::kFrameDropperSupported = true; 305 const bool Debug::kFrameDropperSupported = true;
304 306
305 #undef __ 307 #undef __
306 308
307 #endif // ENABLE_DEBUGGER_SUPPORT 309 #endif // ENABLE_DEBUGGER_SUPPORT
308 310
309 } } // namespace v8::internal 311 } } // namespace v8::internal
310 312
311 #endif // V8_TARGET_ARCH_IA32 313 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | src/type-info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698