Implement target cache for constructor calls.

src/ia32/full-codegen-ia32.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2303 matching lines @@
   ZoneList<Expression*>* args = expr->arguments();
   int arg_count = args->length();
   for (int i = 0; i < arg_count; i++) {
     VisitForStackValue(args->at(i));
   }
 
   // Call the construct call builtin that handles allocation and
   // constructor invocation.
   SetSourcePosition(expr->position());
 
-  // Load function and argument count into edi and eax.
+  // Load function and argument count into edi and eax.  Record call targets
+  // in unoptimized code, but not in the snapshot.
+  bool record_call_target = !Serializer::enabled();
+  CallFunctionFlags flags =
+      record_call_target ? RECORD_CALL_TARGET : NO_CALL_FUNCTION_FLAGS;
+  CallConstructStub stub(flags);
   __ SafeSet(eax, Immediate(arg_count));
   __ mov(edi, Operand(esp, arg_count * kPointerSize));
+  __ call(stub.GetCode(), RelocInfo::CODE_TARGET, expr->id());

[Vyacheslav Egorov (Chromium), 2012/01/23 10:39:52]

RelocInfo::CONSTRUCT_CALL

[Michael Starzinger, 2012/01/25 11:42:29]

Done. Required some changes in the debugger.

 
-  Handle<Code> construct_builtin =
-      isolate()->builtins()->JSConstructCall();
-  __ call(construct_builtin, RelocInfo::CONSTRUCT_CALL);
+  // There is a one element cache in the instruction stream.
+  if (record_call_target) {

[Vyacheslav Egorov (Chromium), 2012/01/23 10:39:52]

I am curious if you can introduce helper method (e.g. on macro assembler?) which
both generates call to stub _and_ emits test eax instruction if necessary. This
way nobody will forget it.

[Michael Starzinger, 2012/01/25 11:42:29]

Done. No longer needed with new approach.

+#ifdef DEBUG
+    int return_site_offset = masm()->pc_offset();
+#endif
+    Handle<Object> uninitialized =
+        CallConstructStub::UninitializedSentinel(isolate());
+    Handle<JSGlobalPropertyCell> cell =
+        isolate()->factory()->NewJSGlobalPropertyCell(uninitialized);
+    __ test(eax, Immediate(cell));
+    // Patching code in the stub assumes the opcode is 1 byte and there is
+    // word for a pointer in the operand.
+    ASSERT(masm()->pc_offset() - return_site_offset >= 1 + kPointerSize);
+  }
+
   context()->Plug(eax);
 }
 
 
 void FullCodeGenerator::EmitIsSmi(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   ASSERT(args->length() == 1);
 
   VisitForAccumulatorValue(args->at(0));
 
@@ skipping 2039 matching lines @@
   *context_length = 0;
   return previous_;
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32