Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 893073002: Start showing basic infobars for manifest apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revised icon storage logic Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index 9f371b8371355a456ca878110a26e4b9b4c6a813..be5d1dc84502eeebf91c0bc5a75b2b3afb166177 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -115,6 +115,11 @@ public class AppBannerManager implements AppBannerView.Observer, AppDetailsDeleg
nativeReplaceWebContents(mNativePointer, mTab.getWebContents());
}
+ @CalledByNative
+ private int getPreferredIconSize() {
+ return AppBannerView.getIconSize(mContentViewCore.getContext());
+ }
+
/**
* Grabs package information for the banner asynchronously.
* @param url URL for the page that is triggering the banner.
@@ -127,7 +132,7 @@ public class AppBannerManager implements AppBannerView.Observer, AppDetailsDeleg
if (sAppDetailsDelegate == null || !isBannerForCurrentPage(url)) return;
- int iconSize = AppBannerView.getIconSize(mContentViewCore.getContext());
+ int iconSize = getPreferredIconSize();
sAppDetailsDelegate.getAppDetailsAsynchronously(this, url, packageName, iconSize);
}
@@ -225,8 +230,8 @@ public class AppBannerManager implements AppBannerView.Observer, AppDetailsDeleg
* @return True if the user is still on the same page.
*/
private boolean isBannerForCurrentPage(String bannerUrl) {
- return mContentViewCore != null &&
- TextUtils.equals(mContentViewCore.getWebContents().getUrl(), bannerUrl);
+ return mContentViewCore != null
+ && TextUtils.equals(mContentViewCore.getWebContents().getUrl(), bannerUrl);
}
private static native boolean nativeIsEnabled();
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/browser/android/banners/app_banner_infobar_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698