Start showing basic infobars for manifest apps

Start showing basic infobars for manifest apps

* Create a new skeleton InfoBarDelegate for app banners containing
  information about apps defined by web manifests.

* Displays an infobar when the user navigates to a page
  with a manifest.

* Adds a string for "Add to homescreen" for the new infobar.

BUG=453170
Committed: https://crrev.com/534f316d9864003080435544066eb41e43dc40be
Cr-Commit-Position: refs/heads/master@{#314273}

[gone, 2015-02-02 21:28:24]

dfalcantara@chromium.org changed reviewers:
+ newt@chromium.org

[gone, 2015-02-02 21:28:24]

Not sure who the best reviewer is for this CL; if you want to punt let me know.

[gone, 2015-02-03 00:09:26]

Squashed the next CL on top since it changes where the icon gets stored.

[newt (away), 2015-02-03 00:57:25]

https://codereview.chromium.org/893073002/diff/20001/chrome/browser/android/b...
File chrome/browser/android/banners/app_banner_infobar_delegate.cc (right):

https://codereview.chromium.org/893073002/diff/20001/chrome/browser/android/b...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:57: gfx::Image
AppBannerInfoBarDelegate::GetIcon() const {
How could delegate_ ever be null? It seems impossible, in which case you
shouldn't handle it. You could add a DCHECK in the CreateForWebApp() method
though.

https://codereview.chromium.org/893073002/diff/20001/chrome/browser/android/b...
File chrome/browser/android/banners/app_banner_infobar_delegate.h (right):

https://codereview.chromium.org/893073002/diff/20001/chrome/browser/android/b...
chrome/browser/android/banners/app_banner_infobar_delegate.h:20: // Handles
calls dealing with blocking, promoting, or grab info about an app.
s/grab/grabbing

https://codereview.chromium.org/893073002/diff/20001/chrome/browser/android/b...
chrome/browser/android/banners/app_banner_infobar_delegate.h:35: const
AppDelegate* helper,
s/helper/delegate ?

Also, document the return value. It surprised me later on to discover that this
could return null.

https://codereview.chromium.org/893073002/diff/20001/chrome/browser/android/b...
chrome/browser/android/banners/app_banner_infobar_delegate.h:43: virtual
gfx::Image GetIcon() const override;
New style guide: don't use virtual with override. Just use override (which
implies virtual).

[gone, 2015-02-03 01:18:16]

Made the changes.  Seemed mostly nitty.  Running through try bots now.

https://chromiumcodereview.appspot.com/893073002/diff/20001/chrome/browser/an...
File chrome/browser/android/banners/app_banner_infobar_delegate.cc (right):

https://chromiumcodereview.appspot.com/893073002/diff/20001/chrome/browser/an...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:57: gfx::Image
AppBannerInfoBarDelegate::GetIcon() const {
On 2015/02/03 00:57:24, newt wrote:
> How could delegate_ ever be null? It seems impossible, in which case you
> shouldn't handle it. You could add a DCHECK in the CreateForWebApp() method
> though.

Done.

https://chromiumcodereview.appspot.com/893073002/diff/20001/chrome/browser/an...
File chrome/browser/android/banners/app_banner_infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/893073002/diff/20001/chrome/browser/an...
chrome/browser/android/banners/app_banner_infobar_delegate.h:20: // Handles
calls dealing with blocking, promoting, or grab info about an app.
On 2015/02/03 00:57:24, newt wrote:
> s/grab/grabbing

Done.

https://chromiumcodereview.appspot.com/893073002/diff/20001/chrome/browser/an...
chrome/browser/android/banners/app_banner_infobar_delegate.h:35: const
AppDelegate* helper,
On 2015/02/03 00:57:24, newt wrote:
> s/helper/delegate ?
> 
> Also, document the return value. It surprised me later on to discover that
this
> could return null.

Done.

https://chromiumcodereview.appspot.com/893073002/diff/20001/chrome/browser/an...
chrome/browser/android/banners/app_banner_infobar_delegate.h:43: virtual
gfx::Image GetIcon() const override;
On 2015/02/03 00:57:25, newt wrote:
> New style guide: don't use virtual with override. Just use override (which
> implies virtual).

Done.

[newt (away), 2015-02-03 01:25:52]

lgtm

[gone, 2015-02-03 02:56:40]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-03 02:58:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/893073002/40001

[commit-bot: I haz the power, 2015-02-03 03:17:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 03:17:14]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (None)

[gone, 2015-02-03 03:19:30]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-03 03:19:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/893073002/40001

[commit-bot: I haz the power, 2015-02-03 05:33:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-03 05:34:10]

Patchset 3 (id:??) landed as
https://crrev.com/534f316d9864003080435544066eb41e43dc40be
Cr-Commit-Position: refs/heads/master@{#314273}