extensions/browser/guest_view/web_view/web_view_guest.cc - Issue 888563003: <webview>: Navigate to about:blank if attempting to navigate to bad URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 888563003: <webview>: Navigate to about:blank if attempting to navigate to bad URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lazyboy's comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/web_view/web_view_constants.h ('K') | « extensions/browser/guest_view/web_view/web_view_constants.cc ('k') | extensions/test/data/web_view/apitest/main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_guest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc

index e9c25ba23e1afb1c42174ed948b7be2d1647e083..c795ee250f9b8847458c709820ce7a8545708b88 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc

@@ -879,6 +879,7 @@ void WebViewGuest::NavigateGuest(const std::string& src,

if (scheme_is_blocked || !url.is_valid()) {

LoadAbort(true /* is_top_level */, url,

net::ErrorToShortString(net::ERR_ABORTED));

+ NavigateGuest(webview::kAboutBlankURL, true /* force_navigation */);

lazyboy 2015/02/03 17:36:40 Sorry for being vague here, I meant to use kAboutB

lazyboy 2015/02/03 17:36:40 Also add a comment here.

return;

}

if (!force_navigation && (src_ == url))