lib/src/protobuf/coded_buffer_reader.dart - Issue 886643002: pkg/protobuf: cleanup and prep for 0.3.5 release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/protobuf/coded_buffer_reader.dart

Issue 886643002: pkg/protobuf: cleanup and prep for 0.3.5 release (Closed) Base URL: https://github.com/dart-lang/dart-protobuf.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/protobuf/coded_buffer_reader.dart

diff --git a/lib/src/protobuf/coded_buffer_reader.dart b/lib/src/protobuf/coded_buffer_reader.dart

index 20fbbab85c23c7885f0a8657109c3ba79d155e7b..fa0b99f70266f12738f6dc0224b9a3a12f8ad7fd 100644

--- a/lib/src/protobuf/coded_buffer_reader.dart

+++ b/lib/src/protobuf/coded_buffer_reader.dart

@@ -61,8 +61,6 @@ class CodedBufferReader {

}

- bool _canRead(int increment) => _bufferPos + increment <= _currentLimit;

void readGroup(int fieldNumber, GeneratedMessage message,

ExtensionRegistry extensionRegistry) {

if (_recursionDepth >= _recursionLimit) {

« no previous file with comments | « README.md ('k') | lib/src/protobuf/generated_message.dart » ('j') | no next file with comments »