Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: Source/modules/accessibility/AXObject.h

Issue 885163002: [Contextual Search] Check for ARIA widget roles. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added aria-attribute check and unit test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/accessibility/AXObject.cpp » ('j') | Source/modules/accessibility/AXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXObject.h
diff --git a/Source/modules/accessibility/AXObject.h b/Source/modules/accessibility/AXObject.h
index f6f29f612749b9c79f0c716fd764fda9ae7d7c4d..dda5b4c405454d107cf0f714bee3ea20903ef10a 100644
--- a/Source/modules/accessibility/AXObject.h
+++ b/Source/modules/accessibility/AXObject.h
@@ -48,6 +48,8 @@ class IntPoint;
class Node;
class RenderObject;
class ScrollableArea;
+class WebElement;
+class WebNode;
class Widget;
typedef unsigned AXID;
@@ -608,6 +610,7 @@ public:
static AccessibilityRole ariaRoleToWebCoreRole(const String&);
static IntRect boundingBoxForQuads(RenderObject*, const Vector<FloatQuad>&);
static const AtomicString& roleName(AccessibilityRole);
+ static bool isARIAWidget(const WebNode&);
dmazzoni 2015/02/05 00:40:23 This should take a Node& instead
Donn Denman 2015/02/06 22:53:36 Done.
protected:
AXID m_id;
@@ -643,6 +646,10 @@ protected:
// Updates the cached attribute values. This may be recursive, so to prevent deadlocks,
// functions called here may only search up the tree (ancestors), not down.
void updateCachedAttributeValuesIfNeeded() const;
+
+private:
+ static bool includesARIAWidgetRole(const String&);
+ static bool hasInteractiveARIAAttribute(const WebElement&);
};
#define DEFINE_AX_OBJECT_TYPE_CASTS(thisType, predicate) \
« no previous file with comments | « no previous file | Source/modules/accessibility/AXObject.cpp » ('j') | Source/modules/accessibility/AXObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698