content/test/test_web_contents.cc - Issue 88503002: Have the unload event execute in background on cross-site navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_web_contents.cc

Issue 88503002: Have the unload event execute in background on cross-site navigations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Keeping the old rvh alive for up to 1s Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/test_web_contents.cc

diff --git a/content/test/test_web_contents.cc b/content/test/test_web_contents.cc

index a2a42e6e0213bc5e795fc863204cd14465474809..2036c9e1b7c4d51e0d39912d169eee3d86cfc828 100644

--- a/content/test/test_web_contents.cc

+++ b/content/test/test_web_contents.cc

@@ -147,7 +147,7 @@ void TestWebContents::CommitPendingNavigation() {

// RVH, before the navigation commits. This is needed when

// cross-site navigation happens (old_rvh != rvh).

if (old_rvh != rvh)

- static_cast<RenderViewHostImpl*>(old_rvh)->OnSwappedOut(false);

+ static_cast<RenderViewHostImpl*>(old_rvh)->OnSwappedOut(false, false);

rvh->SendNavigate(page_id, entry->GetURL());

}