Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: chrome/browser/renderer_host/web_cache_manager_browsertest.cc

Issue 88503002: Have the unload event execute in background on cross-site navigations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Keeping the old rvh alive for up to 1s Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/web_cache_manager_browsertest.cc
diff --git a/chrome/browser/renderer_host/web_cache_manager_browsertest.cc b/chrome/browser/renderer_host/web_cache_manager_browsertest.cc
index a917ed5cba1dbbc8b3a6d9b1e8b265ca62be306c..4c884ae7c4ad3fed2ea4b571e9eb0abacac6d31a 100644
--- a/chrome/browser/renderer_host/web_cache_manager_browsertest.cc
+++ b/chrome/browser/renderer_host/web_cache_manager_browsertest.cc
@@ -57,10 +57,16 @@ IN_PROC_BROWSER_TEST_F(WebCacheManagerBrowserTest, CrashOnceOnly) {
ui_test_utils::NavigateToURL(browser(), url);
- EXPECT_EQ(
- WebCacheManager::GetInstance()->active_renderers_.size(), 1U);
+ // We may have two renderers if one is still executing the unload event in the
Charlie Reis 2013/12/09 20:12:29 Slight concern: Are we likely to have many flaky t
+ // background.
+ EXPECT_GT(
+ WebCacheManager::GetInstance()->active_renderers_.size(), 0U);
+ EXPECT_LT(
+ WebCacheManager::GetInstance()->active_renderers_.size(), 3U);
EXPECT_EQ(
WebCacheManager::GetInstance()->inactive_renderers_.size(), 0U);
- EXPECT_EQ(
- WebCacheManager::GetInstance()->stats_.size(), 1U);
+ EXPECT_GT(
+ WebCacheManager::GetInstance()->stats_.size(), 0U);
+ EXPECT_LT(
+ WebCacheManager::GetInstance()->stats_.size(), 3U);
}

Powered by Google App Engine
This is Rietveld 408576698