content/browser/renderer_host/render_widget_host_impl.cc - Issue 88503002: Have the unload event execute in background on cross-site navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 88503002: Have the unload event execute in background on cross-site navigations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase + addressed some of Nasko's comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index ea985e40fc730d2017aba1a831f23f958ff60a02..bf144ecd7b1c35e1d5a629f884591d9ba67b00e1 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -311,7 +311,8 @@ scoped_ptr<RenderWidgetHostIterator> RenderWidgetHost::GetRenderWidgetHosts() {

// Add only active RenderViewHosts.

RenderViewHost* rvh = RenderViewHost::From(widget);

- if (!static_cast<RenderViewHostImpl*>(rvh)->is_swapped_out())

+ if (RenderViewHostImpl::IsRVHStateActive(

+ static_cast<RenderViewHostImpl*>(rvh)->rvh_state()))

hosts->Add(widget);

}