Have the unload event execute in background on cross-site navigations

content/public/browser/render_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 
 #include "base/basictypes.h"
 #include "base/id_map.h"
 #include "base/process/kill.h"
@@ skipping 11 matching lines @@
 namespace base {
 class TimeDelta;
 }
 
 namespace content {
 class BrowserContext;
 class BrowserMessageFilter;
 class RenderProcessHostObserver;
 class RenderWidgetHost;
 class StoragePartition;
+struct GlobalRequestID;
 
 typedef base::Thread* (*RendererMainThreadFactoryFunction)(
     const std::string& id);
 
 // Interface that represents the browser side of the browser <-> renderer
 // communication channel. There will generally be one RenderProcessHost per
 // renderer process.
 class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
                                          public IPC::Listener,
                                          public base::SupportsUserData {
@@ skipping 168 matching lines @@
   // Checks that the given renderer can request |url|, if not it sets it to
   // about:blank.
   // |empty_allowed| must be set to false for navigations for security reasons.
   virtual void FilterURL(bool empty_allowed, GURL* url) = 0;
 
 #if defined(ENABLE_WEBRTC)
   virtual void EnableAecDump(const base::FilePath& file) = 0;
   virtual void DisableAecDump() = 0;
 #endif
 
+  // Tells the ResourceDispatcherHost to resume a deferred navigation without
+  // transferring it to a new renderer process.
+  virtual void ResumeDeferredNavigation(const GlobalRequestID& request_id) = 0;

[nasko, 2014/01/23 23:34:58]

Why is this a public method now? I don't see anyone outside of content using it
in your patch.

[clamy, 2014/01/24 17:01:54]

The method used to be in RenderProcessHostImpl, where it was public. It is
called in RenderFrameHostManager::SwappedOut where we static_cast a
RenderProcessHost into a RenderProcessHostImpl. In one of the unit_tests, we use
MockRenderProcessHost and happen, because of the patch, to hit this particular
cast when we previously did not (because the call to delegate_->SwappedOut(this)
in the RVH moved from OnSwappedOut to SwapOut). Since MockRenderProcessHost is
not derived from RenderProcessHostImpl, this was causing problems, and I had to
move this specific method to the parent class of RenderProcessHostImpl and
MockRenderProcessHost, that is here, in RenderProcessHost.

[jam, 2014/02/04 23:42:37]

This is an unfortunate side effect of having the public interface of
RenderProcessHostImpl be the same base class for the mock version. I did this
because I didn't want to create yet another base class for RPH when we added the
content api. if it's just one test, and you can find a way to rewrite it as a
browser test (where all implementations will be RenderProcessHostImpl), that
would be great. if not, ok.

[clamy, 2014/02/05 14:21:42]

I think I will leave it as it is now, as this is already quite a big change, and
am not really sure about rewriting the unit test into a browser test.

+
   // Static management functions -----------------------------------------------
 
   // Flag to run the renderer in process.  This is primarily
   // for debugging purposes.  When running "in process", the
   // browser maintains a single RenderProcessHost which communicates
   // to a RenderProcess which is instantiated in the same process
   // with the Browser.  All IPC between the Browser and the
   // Renderer is the same, it's just not crossing a process boundary.
 
   static bool run_renderer_in_process();
@@ skipping 41 matching lines @@
   // module.
   static size_t GetMaxRendererProcessCount();
 
   static void RegisterRendererMainThreadFactory(
       RendererMainThreadFactoryFunction create);
 };
 
 }  // namespace content.
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_