Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: pkg/dart2js_incremental/lib/library_updater.dart

Issue 882713008: Move computation of method flags into model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: use unused api Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/use_unused_api.dart ('k') | tests/compiler/dart2js/analyze_unused_dart2js_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dart2js_incremental/lib/library_updater.dart
diff --git a/pkg/dart2js_incremental/lib/library_updater.dart b/pkg/dart2js_incremental/lib/library_updater.dart
index f0dc55abea331536a5c129e68096c2a6ef3164fb..d3f89e1a7fba07ae3a083d31f09f6db7003d8b9c 100644
--- a/pkg/dart2js_incremental/lib/library_updater.dart
+++ b/pkg/dart2js_incremental/lib/library_updater.dart
@@ -67,7 +67,8 @@ import 'package:compiler/src/js_emitter/js_emitter.dart' show
computeMixinClass;
import 'package:compiler/src/js_emitter/model.dart' show
- Class;
+ Class,
+ Member;
import 'package:compiler/src/js_emitter/program_builder.dart' show
ProgramBuilder;
@@ -931,17 +932,18 @@ if (this.pendingStubs) {
}
jsAst.Node computeMethodUpdateJs(Element element) {
- MemberInfo info = containerBuilder.analyzeMemberMethod(element);
- if (info == null) {
+ Member member = new ProgramBuilder(compiler, namer, emitter)
+ .buildMethodHackForIncrementalCompilation(element);
+ if (member == null) {
compiler.internalError(element, '${element.runtimeType}');
}
ClassBuilder builder = new ClassBuilder(element, namer);
- containerBuilder.addMemberMethodFromInfo(info, builder);
+ containerBuilder.addMemberMethod(member, builder);
jsAst.Node partialDescriptor =
builder.toObjectInitializer(emitClassDescriptor: false);
- String name = info.name;
- jsAst.Node function = info.code;
+ String name = member.name;
+ jsAst.Node function = member.code;
bool isStatic = !element.isInstanceMember;
/// Either a global object (non-instance members) or a prototype (instance
« no previous file with comments | « pkg/compiler/lib/src/use_unused_api.dart ('k') | tests/compiler/dart2js/analyze_unused_dart2js_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698