Cryptohome: Notify about error in async calls if cryptohome is not ready yet.

chromeos/dbus/cryptohome_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_
 #define CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 16 matching lines @@
 class GetKeyDataRequest;
 class MountRequest;
 class RemoveKeyRequest;
 class SetBootAttributeRequest;
 class UpdateKeyRequest;
 
 } // namespace cryptohome
 
 namespace chromeos {
 
+// Constant that will be passed to AsyncMethodCallback to indicate that
+// cryptohome is not ready yet.
+extern const int kCryptohomeNotReadyAsyncId;

[Daniel Erat, 2015/01/28 18:01:46]

can you make this be a public static member of CryptohomeClient (with a shorter
name) instead of putting it directly into the cryptohome namespace? that makes
it easier to see where it's defined when reading code that uses it.

e.g.

class ... CryptohomeClient ... {
 public:
  static const int kNotReadyAsyncId;

[Denis Kuznetsov (DE-MUC), 2015/01/28 19:45:26]

Done.

+
 // CryptohomeClient is used to communicate with the Cryptohome service.
 // All method should be called from the origin thread (UI thread) which
 // initializes the DBusThreadManager instance.
 class CHROMEOS_EXPORT CryptohomeClient : public DBusClient {
  public:
   // A callback to handle AsyncCallStatus signals.
   typedef base::Callback<void(int async_id,
                               bool return_status,
                               int return_code)>
       AsyncCallStatusHandler;
@@ skipping 495 matching lines @@
   // Create() should be used instead.
   CryptohomeClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CryptohomeClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_