content/browser/android/web_contents_observer_android.h - Issue 877163005: [Android] Fix new tab not to show 'about:blank' at the beginning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_android.h

Issue 877163005: [Android] Fix new tab not to show 'about:blank' at the beginning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java ('k') | content/browser/android/web_contents_observer_android.cc » ('j') | content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/web_contents_observer_android.h

diff --git a/content/browser/android/web_contents_observer_android.h b/content/browser/android/web_contents_observer_android.h

index 6601d15a612511225953e08eafbdd54cd9ce4534..2fe71948d5dc174184d0fd8cbeab8bc69510793b 100644

--- a/content/browser/android/web_contents_observer_android.h

+++ b/content/browser/android/web_contents_observer_android.h

@@ -72,6 +72,9 @@ class WebContentsObserverAndroid : public WebContentsObserver {

virtual void DidAttachInterstitialPage() override;

virtual void DidDetachInterstitialPage() override;

virtual void DidChangeThemeColor(SkColor color) override;

+ virtual void DidStartNavigationToPendingEntry(

David Trainor- moved to gerrit 2015/01/29 21:24:21 Remove virtual (not supposed to have it with overr

Changwan Ryu 2015/01/30 00:03:24 Done.

+ const GURL& url,

+ NavigationController::ReloadType reload_type) override;

void DidFailLoadInternal(bool is_provisional_load,

bool is_main_frame,