sandbox/linux/BUILD.gn - Issue 877153005: sandbox: extract SetuidSandboxHost code from SetuidSandboxClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/BUILD.gn

Issue 877153005: sandbox: extract SetuidSandboxHost code from SetuidSandboxClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to rickyz feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/zygote_host/zygote_host_impl_linux.cc ('k') | sandbox/linux/sandbox_linux.gypi » ('j') | sandbox/linux/suid/client/setuid_sandbox_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sandbox/linux/BUILD.gn

diff --git a/sandbox/linux/BUILD.gn b/sandbox/linux/BUILD.gn

index 96df5fd69b286adaa3d944a294828f42208c65ac..26aca427c64b09f3db5520d657139edb6c31b908 100644

--- a/sandbox/linux/BUILD.gn

+++ b/sandbox/linux/BUILD.gn

@@ -94,7 +94,10 @@ test("sandbox_linux_unittests") {

}

if (compile_suid_client) {

- sources += [ "suid/client/setuid_sandbox_client_unittest.cc" ]

+ sources += [

+ "suid/client/setuid_sandbox_client_unittest.cc",

+ "suid/client/setuid_sandbox_host_unittest.cc",

+ ]

}

if (use_seccomp_bpf) {

sources += [

@@ -306,6 +309,8 @@ if (compile_suid_client) {

"suid/common/suid_unsafe_environment_variables.h",

"suid/client/setuid_sandbox_client.cc",

"suid/client/setuid_sandbox_client.h",

+ "suid/client/setuid_sandbox_host.cc",

+ "suid/client/setuid_sandbox_host.h",

]

defines = [ "SANDBOX_IMPLEMENTATION" ]