Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.h
diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h
index 649e62885c4775bb9b62e6cf8cae7ee0822abda0..98121628020a6f476b3409ff66fce0c59fb39b3c 100644
--- a/content/browser/frame_host/navigation_request.h
+++ b/content/browser/frame_host/navigation_request.h
@@ -110,6 +110,7 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {
void OnResponseStarted(const scoped_refptr<ResourceResponse>& response,
scoped_ptr<StreamHandle> body) override;
void OnRequestFailed(int net_error) override;
+ void AboutToBeginNavigation(base::TimeTicks timestamp) override;
clamy 2015/01/27 12:35:03 How about NavigationStarted? This is called after
carlosk 2015/01/27 17:12:03 Agreed but I don't think NavigationStarted is much
clamy 2015/01/28 13:44:21 I don't like AboutToAttemptFirstNetworkRequest muc
carlosk 2015/01/28 15:21:08 I agree with your point on the AboutTo not being p
FrameTreeNode* frame_tree_node_;
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_request.cc » ('j') | content/browser/frame_host/navigation_request.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698