Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: content/browser/frame_host/navigator.h

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Final method name change. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 191a58366227634b7e51db019cc8cdf6f5453019..e56335ad5a77458cfb06b1407eb362149370cf10 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -138,8 +138,12 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
// |frame_tree_node| is destroyed.
virtual void CancelNavigation(FrameTreeNode* frame_tree_node) {}
- // Called when the first resource request for a given navigation is executed
- // so that it can be tracked into an histogram.
+ // Called when the network stack started handling the navigation request
+ // so that the |timestamp| when it happened can be recorded into an histogram.
+ // The |url| is used to verify we're tracking the correct navigation.
+ // TODO(carlosk): once PlzNavigate is the only navigation implementation
+ // remove the URL parameter and rename this method to better suit its naming
+ // conventions.
virtual void LogResourceRequestTime(
base::TimeTicks timestamp, const GURL& url) {};
« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698