Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 // PlzNavigate 136 // PlzNavigate
137 // Cancel a NavigationRequest for |frame_tree_node|. Called when 137 // Cancel a NavigationRequest for |frame_tree_node|. Called when
138 // |frame_tree_node| is destroyed. 138 // |frame_tree_node| is destroyed.
139 virtual void CancelNavigation(FrameTreeNode* frame_tree_node) {} 139 virtual void CancelNavigation(FrameTreeNode* frame_tree_node) {}
140 140
141 // Called when the first resource request for a given navigation is executed 141 // Called when the first resource request for a given navigation is executed
142 // so that it can be tracked into an histogram. 142 // so that it can be tracked into an histogram.
143 virtual void LogResourceRequestTime( 143 virtual void LogResourceRequestTime(
144 base::TimeTicks timestamp, const GURL& url) {}; 144 base::TimeTicks timestamp, const GURL& url) {};
145 145
146 // PlzNavigate
147 // Called when ResourceDispacherHostImpl is about to begin working on a
clamy 2015/01/27 12:35:04 s/is about to begin working/has started working
carlosk 2015/01/27 17:12:03 Done.
148 // navigation request, right before the first network request is made so that
149 // the timestamp can be recorded into an histogram.
150 virtual void LogAboutToBeginNavigation(base::TimeTicks timestamp) {};
carlosk 2015/01/26 19:54:01 I switched the method name here, adding the Log pr
clamy 2015/01/27 12:35:03 Acknowledged.
151
146 // Called to record the time it took to execute the before unload hook for the 152 // Called to record the time it took to execute the before unload hook for the
147 // current navigation. 153 // current navigation.
148 virtual void LogBeforeUnloadTime( 154 virtual void LogBeforeUnloadTime(
149 const base::TimeTicks& renderer_before_unload_start_time, 155 const base::TimeTicks& renderer_before_unload_start_time,
150 const base::TimeTicks& renderer_before_unload_end_time) {} 156 const base::TimeTicks& renderer_before_unload_end_time) {}
151 157
152 // PlzNavigate 158 // PlzNavigate
153 // Returns whether there is an ongoing navigation waiting for the BeforeUnload 159 // Returns whether there is an ongoing navigation waiting for the BeforeUnload
154 // event to execute in the renderer process. 160 // event to execute in the renderer process.
155 virtual bool IsWaitingForBeforeUnloadACK(FrameTreeNode* frame_tree_node); 161 virtual bool IsWaitingForBeforeUnloadACK(FrameTreeNode* frame_tree_node);
156 162
157 protected: 163 protected:
158 friend class base::RefCounted<Navigator>; 164 friend class base::RefCounted<Navigator>;
159 virtual ~Navigator() {} 165 virtual ~Navigator() {}
160 }; 166 };
161 167
162 } // namespace content 168 } // namespace content
163 169
164 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 170 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698